Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-router-outlet interferes with layouting / sizing of components #20767

Open
Artur- opened this issue Dec 20, 2024 · 0 comments · May be fixed by #20771
Open

react-router-outlet interferes with layouting / sizing of components #20767

Artur- opened this issue Dec 20, 2024 · 0 comments · May be fixed by #20771

Comments

@Artur-
Copy link
Member

Artur- commented Dec 20, 2024

Description of the bug

When you put a Hilla view inside a Flow main layout, you get a < react-router-outlet> element between the main layout component and the Hilla view. This affects how the view is sized, e.g. 100% view width does not work

Expected behavior

react-router-outlet should have display: contents so it is does affect layouting

Minimal reproducible example

Artur-/flow-crud-demo@9e05db7

Versions

  • Vaadin / Flow version: 24.7
@Artur- Artur- linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ReactRouterOutlet interferes with layout vaadin/flow
1 participant
@Artur-