Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FeatureFlags#EXAMPLE #21029

Open
AB-xdev opened this issue Feb 21, 2025 · 1 comment · May be fixed by #21030
Open

Remove FeatureFlags#EXAMPLE #21029

AB-xdev opened this issue Feb 21, 2025 · 1 comment · May be fixed by #21030
Assignees

Comments

@AB-xdev
Copy link

AB-xdev commented Feb 21, 2025

FeatureFlags#EXAMPLE states:

Example feature. Will be removed once the first real feature flag is added

It should therefore be removed

public static final Feature EXAMPLE = new Feature(
"Example feature. Will be removed once the first real feature flag is added",
"exampleFeatureFlag", "https://github.com/vaadin/flow/pull/12004",
false,
"com.vaadin.flow.server.frontend.NodeTestComponents$ExampleExperimentalComponent");

@mcollovati
Copy link
Collaborator

As commented in the linked PR, removing the flag would negatively impact the quality of code base tests, because of workarounds that should be introduced to verify all functionalities related to feature flags.

I propose to preserve the feature, and update the description to state that it is there for testing purpose.

public static final Feature EXAMPLE = new Feature(
  "Example feature. Internally used for testing purposes. Does not have any effect on production applications.",
  "exampleFeatureFlag", "https://github.com/vaadin/flow/pull/12004",
  false,
  "com.vaadin.flow.server.frontend.NodeTestComponents$ExampleExperimentalComponent");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ⚒️ In progress
Development

Successfully merging a pull request may close this issue.

3 participants