Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCDM: UI.getCurrent().getElement().appendChild does not work in V15 #332

Open
manolo opened this issue Feb 14, 2020 · 1 comment
Open

CCDM: UI.getCurrent().getElement().appendChild does not work in V15 #332

manolo opened this issue Feb 14, 2020 · 1 comment
Labels
bug Something isn't working hilla Issues related to Hilla Impact: Low Severity: Minor

Comments

@manolo
Copy link
Member

manolo commented Feb 14, 2020

JavaScriptBootstrapUI puts the view in a wrapper appended as a virtualChild.

We might override the getElement() to return the wrapper, it apparently works, but breaks $server methods in client side.
After a further investigation, I saw that the problem is that gwt ServerEventObject class puts the $server method in body (put attention in the initPromiseHandler) whereas calls to this method from server side are bound to the wrapper element (see PublishedServerEventHandlerRpcHandler.invokeMethod).

@manolo manolo added bug Something isn't working hilla Issues related to Hilla labels Feb 14, 2020
@joheriks
Copy link

Note that this also means that @PreserveOnRefresh is broken for dialogs in V15+. Reloading the page causes open dialogs to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hilla Issues related to Hilla Impact: Low Severity: Minor
Projects
None yet
Development

No branches or pull requests

3 participants