Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance problem in rendering #128

Closed
Artur- opened this issue Apr 10, 2019 · 3 comments
Closed

Performance problem in rendering #128

Artur- opened this issue Apr 10, 2019 · 3 comments
Assignees
@Haprog @web-padawan

Comments

@Artur-
Copy link
Member

Artur- commented Apr 10, 2019

Creating a button with any text causes style recalculations during rendering. This leads to vaadin/flow#5447

Screenshot 2019-04-10 at 9 37 07
@web-padawan
Copy link
Member

Already agreed on reverting #122 and #125 to fix that (it would also fix #127)

@web-padawan
Copy link
Member

Note, the true reason is using innerText but I still think we need to revert because of #127.

@pleku pleku mentioned this issue Apr 10, 2019
Closed
@web-padawan
Copy link
Member

Closing as the code introducing this has been reverted and fix released in 2.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Haprog Haprog

@web-padawan web-padawan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Haprog @Artur- @web-padawan