-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date Picker doesn't display error messages #224
Comments
@tomivirkki, what would it mean to add this? It would probably need some documentation from our side as well, right? |
@jouni I ended up playing around with it and adding the error-message itself is relatively easy. Just a matter of adding a new property and adding: <template is="dom-if" if="[[errorMessage]]">
<paper-input-error aria-live="assertive">[[errorMessage]]</paper-input-error>
</template> Overall the change is fairly simple, however a secondary issue is that the date-picker becomes invalid fairly easily. Example
Steps to Reproduce
|
@nick-woodward and @jouni The Note that you can already add any custom content inside the date picker by using |
@tomivirkki Awesome, I was unaware the light version was so flexible. Not overly surprising, but it looks like the light version has the same issue as the regular version regarding validation. However, it looks like the validation issue is somewhat documented in the code as a |
Seeing how
vaadin-combo-box
and the paper components generally allow for an error-message I would expect the date-picker to be the same.The text was updated successfully, but these errors were encountered: