Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0][Enhancement Request] Hybrid support #887

Closed
t2ym opened this issue Jun 1, 2017 · 3 comments
Closed

[3.0][Enhancement Request] Hybrid support #887

t2ym opened this issue Jun 1, 2017 · 3 comments

Comments

@t2ym
Copy link

t2ym commented Jun 1, 2017

Is it possible to support hybrid dependencies as follows like the standard Polymer elements such as paper-input?

diff --git a/bower.json b/bower.json
index d176bcc..7027c07 100644
--- a/bower.json
+++ b/bower.json
@@ -47,11 +47,11 @@
     "app-localize-behavior": "^v2.0.0"
   },
   "dependencies": {
-    "polymer": "^2.0.0",
-    "iron-resizable-behavior": "PolymerElements/iron-resizable-behavior#^v2.0.0",
-    "iron-scroll-target-behavior": "PolymerElements/iron-scroll-target-behavior#^v2.0.0",
-    "iron-a11y-keys-behavior": "^v2.0.0",
-    "iron-a11y-announcer": "^v2.0.0"
+    "polymer": "Polymer/polymer#1.9 - 2",
+    "iron-resizable-behavior": "PolymerElements/iron-resizable-behavior#1 - 2",
+    "iron-scroll-target-behavior": "PolymerElements/iron-scroll-target-behavior#1 - 2",
+    "iron-a11y-keys-behavior": "PolymerElements/iron-a11y-keys-behavior#1 - 2",
+    "iron-a11y-announcer": "PolymerElements/iron-a11y-announcer#1 - 2"
   },
   "variants": {
     "1.x": {
@samiheikki
Copy link
Contributor

Hi @t2ym. I discussed with our team and this could be possible for us to do. Have you tried out installing 3.0 on your app? Does bower automatically resolve the conflicted dependencies or are you required to resolve them manually?

@t2ym
Copy link
Author

t2ym commented Jun 1, 2017

Hi @samiheikki.

vaadin-grid#3.0.0 requires a manual resolution with polymer#^1.9.0 since it explicitly depends on polymer#^2.0.0 and conflicts with polymer#^1.9.0.

As vaadin-grid#3.0.0 is tested on polymer 1.x, it should support polymer 1.x as well as polymer 2.x with automatic hybrid resolution. The required change is just the same one as shown in my first comment.

Note: This comment was updated after the vaadin-grid#3.0.0 release.

@web-padawan
Copy link
Member

Fixed in #1059 and released in v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants