Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only output greeting message on first install #40

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jul 31, 2019

Fixes #39


This change is Reviewable

@web-padawan web-padawan requested a review from Artur- July 31, 2019 12:24
check.js Outdated
@@ -1,6 +1,9 @@
var fs = require('fs');

const disabledForMachine = process.env.npm_package_config_disabled;
const greetingLogged = process.env.npm_package_config_logged;
const optoutLogged = process.env.npm_package_config_optout;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be less confusing is named optoutLogged or similar. Now it is easy to confuse it with disabled (which actually means that the user has optedout)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@Artur- Artur- merged commit 4b0ecf6 into master Aug 1, 2019
@Artur- Artur- deleted the logged branch August 1, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output message only once per installation
2 participants