Skip to content

Commit 1670f57

Browse files
fix: validate date-time-picker when required is set to false (#7908) (#7914)
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
1 parent 82a81c7 commit 1670f57

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

packages/date-time-picker/src/vaadin-date-time-picker.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -715,6 +715,12 @@ class DateTimePicker extends FieldMixin(DisabledMixin(FocusMixin(ThemableMixin(E
715715
if (timePicker) {
716716
timePicker.required = required;
717717
}
718+
719+
if (this.__oldRequired && !required) {
720+
this.validate();
721+
}
722+
723+
this.__oldRequired = required;
718724
}
719725

720726
/** @private */

packages/date-time-picker/test/validation.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,11 @@ const fixtures = {
200200
dateTimePicker.validate();
201201
expect(dateTimePicker.invalid).to.be.true;
202202
});
203+
204+
it('should validate when setting required to false', () => {
205+
dateTimePicker.required = false;
206+
expect(validateSpy).to.be.calledOnce;
207+
});
203208
});
204209

205210
describe('document losing focus', () => {

0 commit comments

Comments
 (0)