fix: clear value when removing the last input (#8270) (#8277)

Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com> Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
vaadin · Dec 5, 2024 · 4b7db8b · 4b7db8b
1 parent 642df30
commit 4b7db8b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/custom-field/src/vaadin-custom-field-mixin.js b/packages/custom-field/src/vaadin-custom-field-mixin.js
@@ -272,6 +272,9 @@ export const CustomFieldMixin = (superClass) =>
     /** @private */
     __inputsChanged(inputs, oldInputs) {
       if (inputs.length === 0) {
+        if (oldInputs && oldInputs.length > 0) {
+          this.__setValue();
+        }
         return;
       }
 

diff --git a/packages/custom-field/test/custom-field.common.js b/packages/custom-field/test/custom-field.common.js
@@ -88,6 +88,19 @@ describe('custom field', () => {
         expect(el.value).to.equal('');
       });
     });
+
+    it('should update value when removing inputs', async () => {
+      customField.value = '1\t1';
+      await nextUpdate(customField);
+
+      customField.removeChild(customField.inputs[0]);
+      await nextUpdate(customField);
+      expect(customField.value).to.equal('1');
+
+      customField.removeChild(customField.inputs[0]);
+      await nextUpdate(customField);
+      expect(customField.value).to.equal('');
+    });
   });
 
   describe('value set with attribute', () => {