fix: allow helper disallowed char patterns set for input (#7521) (#7526)

vaadin · Jul 10, 2024 · 89fcc31 · 89fcc31
1 parent d89fa78
commit 89fcc31
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/field-base/src/input-control-mixin.js b/packages/field-base/src/input-control-mixin.js
@@ -189,7 +189,7 @@ export const InputControlMixin = (superclass) =>
     _onKeyDown(event) {
       super._onKeyDown(event);
 
-      if (this.allowedCharPattern && !this.__shouldAcceptKey(event)) {
+      if (this.allowedCharPattern && !this.__shouldAcceptKey(event) && event.target === this.inputElement) {
         event.preventDefault();
         this._markInputPrevented();
       }

diff --git a/packages/field-base/test/input-control-mixin.test.js b/packages/field-base/test/input-control-mixin.test.js
@@ -10,6 +10,7 @@ import {
   nextRender,
   nextUpdate,
 } from '@vaadin/testing-helpers';
+import { sendKeys } from '@web/test-runner-commands';
 import sinon from 'sinon';
 import { isTouch } from '@vaadin/component-base/src/browser-utils.js';
 import { ControllerMixin } from '@vaadin/component-base/src/controller-mixin.js';
@@ -369,6 +370,16 @@ const runTests = (defineHelper, baseMixin) => {
         element._preventInputDebouncer.flush();
         expect(element.hasAttribute('input-prevented')).to.be.false;
       });
+
+      it('should not prevent input for other slotted inputs', async () => {
+        const checkbox = fixtureSync(`<input type="checkbox" slot="helper"/>`);
+        element.appendChild(checkbox);
+        checkbox.focus();
+
+        await sendKeys({ press: 'Space' });
+
+        expect(checkbox.checked).to.be.true;
+      });
     });
 
     const fireDropEvent = (draggedText) => {