fix: remove double header border when using column groups without header (#6993)

sissbruecker · web-flow · commit 943534de4e4a · 2023-12-20T17:14:05.000+01:00
* fix: remove double header border when using column groups without header

* add missing material screenshots

* remove ineffective test
diff --git a/packages/grid/theme/lumo/vaadin-grid-styles.js b/packages/grid/theme/lumo/vaadin-grid-styles.js
@@ -213,6 +213,11 @@ registerStyles(
       border-top: 0;
     }
 
+    /* Hide header row top border if previous row is hidden */
+    [part~='row'][hidden] + [part~='row'] [part~='header-cell'] {
+      border-top: 0;
+    }
+
     [part~='row']:last-child [part~='header-cell'] {
       border-bottom: var(--_lumo-grid-border-width) solid transparent;
     }

Original file line number	Diff line number	Diff line change
`@@ -213,6 +213,11 @@ registerStyles(`
`213`	`213`	`border-top: 0;`
`214`	`214`	`}`
`215`	`215`
	`216`	`+ /* Hide header row top border if previous row is hidden */`
	`217`	`+ [part~='row'][hidden] + [part~='row'] [part~='header-cell'] {`
	`218`	`+ border-top: 0;`
	`219`	`+ }`
	`220`	`+`
`216`	`221`	`[part~='row']:last-child [part~='header-cell'] {`
`217`	`222`	`border-bottom: var(--_lumo-grid-border-width) solid transparent;`
`218`	`223`	`}`