fix: add click listener in constructor to ensure listener order (#7184)…

… (#7206)
vaadin · Mar 14, 2024 · b6f98ee · b6f98ee
1 parent e258af3
commit b6f98ee
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/packages/grid/src/vaadin-grid-tree-toggle-mixin.js b/packages/grid/src/vaadin-grid-tree-toggle-mixin.js
@@ -125,10 +125,8 @@ export const GridTreeToggleMixin = (superClass) =>
       };
     }
 
-    /** @protected */
-    ready() {
-      super.ready();
-
+    constructor() {
+      super();
       this.addEventListener('click', (e) => this._onClick(e));
     }
 

diff --git a/packages/grid/test/tree-toggle.common.js b/packages/grid/test/tree-toggle.common.js
@@ -49,6 +49,17 @@ describe('tree toggle', () => {
 
         toggle.removeEventListener('expanded-changed', spy);
       });
+
+      it('should have the correct expanded state on listener invocation', (done) => {
+        toggle = document.createElement('vaadin-grid-tree-toggle');
+        toggle.addEventListener('click', () => {
+          expect(toggle.expanded).to.be.true;
+          done();
+        });
+        const wrapper = fixtureSync('<div></div>');
+        wrapper.append(toggle);
+        click(toggle);
+      });
     });
 
     describe('level', () => {