Skip to content

Commit b6f98ee

Browse files
authored
fix: add click listener in constructor to ensure listener order (#7184) (#7206)
1 parent e258af3 commit b6f98ee

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

packages/grid/src/vaadin-grid-tree-toggle-mixin.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,8 @@ export const GridTreeToggleMixin = (superClass) =>
125125
};
126126
}
127127

128-
/** @protected */
129-
ready() {
130-
super.ready();
131-
128+
constructor() {
129+
super();
132130
this.addEventListener('click', (e) => this._onClick(e));
133131
}
134132

packages/grid/test/tree-toggle.common.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,17 @@ describe('tree toggle', () => {
4949

5050
toggle.removeEventListener('expanded-changed', spy);
5151
});
52+
53+
it('should have the correct expanded state on listener invocation', (done) => {
54+
toggle = document.createElement('vaadin-grid-tree-toggle');
55+
toggle.addEventListener('click', () => {
56+
expect(toggle.expanded).to.be.true;
57+
done();
58+
});
59+
const wrapper = fixtureSync('<div></div>');
60+
wrapper.append(toggle);
61+
click(toggle);
62+
});
5263
});
5364

5465
describe('level', () => {

0 commit comments

Comments
 (0)