refactor: update select to use overlay focus restoration logic (#7601)

Author: web-padawan

packages/select/src/vaadin-select-base-mixin.js

@@ -378,7 +378,6 @@ export const SelectBaseMixin = (superClass) =>
           this.removeAttribute('focus-ring');
         }
       } else if (wasOpened) {
-        this.focus();
         if (this._openedWithFocusRing) {
           this.setAttribute('focus-ring', '');
         }

packages/select/src/vaadin-select-overlay-mixin.js

@@ -19,6 +19,13 @@ export const SelectOverlayMixin = (superClass) =>
       return ['_updateOverlayWidth(opened, owner)'];
     }
 
+    /** @protected */
+    ready() {
+      super.ready();
+
+      this.restoreFocusOnClose = true;
+    }
+
     /** @protected */
     _getMenuElement() {
       return Array.from(this.children).find((el) => el.localName !== 'style');

packages/select/test/keyboard.common.js

@@ -1,5 +1,5 @@
 import { expect } from '@esm-bundle/chai';
-import { fixtureSync, nextRender, nextUpdate } from '@vaadin/testing-helpers';
+import { aTimeout, fixtureSync, nextRender, nextUpdate, outsideClick } from '@vaadin/testing-helpers';
 import { sendKeys } from '@web/test-runner-commands';
 import sinon from 'sinon';
 
@@ -67,7 +67,7 @@ describe('keyboard', () => {
       });
     });
 
-    it('should focus value button element on overlay closing', async () => {
+    it('should focus value button element on overlay closing with Esc', async () => {
       await sendKeys({ press: 'Tab' });
 
       await sendKeys({ press: 'Enter' });
@@ -81,6 +81,21 @@ describe('keyboard', () => {
       expect(focusedSpy.calledOnce).to.be.true;
     });
 
+    it('should focus value button element on overlay closing with outside click', async () => {
+      await sendKeys({ press: 'Tab' });
+
+      await sendKeys({ press: 'Enter' });
+      await nextRender();
+
+      const focusedSpy = sinon.spy(valueButton, 'focus');
+
+      outsideClick();
+      await nextUpdate(select);
+      await aTimeout(0);
+
+      expect(focusedSpy.calledOnce).to.be.true;
+    });
+
     it('should restore focus-ring attribute on overlay closing', async () => {
       await sendKeys({ press: 'Tab' });