You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a known issue of Lerna known as "phantom dependencies".
It comes from the way how bootstrapping works when using Lerna + Yarn workspaces.
Describe the solution you'd like
Consider using Lerna 5.5.0 that added pnpm support for workspaces.
One thing that pnpm provides with its symlinked module structrue (if you don't use --shamefully-hoist) is that it isolates modules well, so there is no phantom dependency problem. We need to check if this feature can be used with Lerna.
The text was updated successfully, but these errors were encountered:
Confirmed that this setup reports all the missing packages when running tests with web-test-runner.
Based on this research, the following PRs have been submitted to address various findings:
One remaining problem when using pnpm is test/typings folder that imports legacy component packages.
We should remove that folder completely, alongside with removal of deprecated packages in Vaadin 24.
Conclusion
I propose to implement pnpm support after 24.0 is out, so that we no longer need to maintain 23.2 branch.
Otherwise, we would have to manually backport some of the PRs listed above (missing dependencies).
web-padawan
changed the title
Investigate using Lerna 5 with pnpm instead of yarn workspaces
Use Lerna 6 with pnpm instead of yarn workspaces
Oct 13, 2022
Describe your motivation
We had a few cases when some npm dependency was missing:
This is a known issue of Lerna known as "phantom dependencies".
It comes from the way how bootstrapping works when using Lerna + Yarn workspaces.
Describe the solution you'd like
Consider using Lerna 5.5.0 that added
pnpm
support for workspaces.One thing that
pnpm
provides with its symlinked module structrue (if you don't use--shamefully-hoist
) is that it isolates modules well, so there is no phantom dependency problem. We need to check if this feature can be used with Lerna.The text was updated successfully, but these errors were encountered: