Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document holiday categories #1717

Open
arkid15r opened this issue Mar 5, 2024 · 2 comments
Open

Document holiday categories #1717

arkid15r opened this issue Mar 5, 2024 · 2 comments

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Mar 5, 2024

Also, what is the definition and criteria for UNOFFICIAL (this seems to be missing from the documentation as well)? Would National Fruitcake Toss Day be included in this library or not? If so, why?

Originally posted by @mborsetti in #1669 (comment)

We should add a section explaining each holiday category purpose with holiday examples (ideally multiple entities holidays would be included).

@arkid15r
Copy link
Collaborator Author

arkid15r commented Mar 5, 2024

@mborsetti please feel free to add/correct the description in case I'm missing something.

@PPsyrius
Copy link
Collaborator

PPsyrius commented Mar 5, 2024

We can probably start with PUBLIC ones, which are officially recognized holidays that applies to everyone in a particular jurisdiction.

WORKDAY on the other hand are observed by that jurisdiction's government but no holidays are given. Example for this would be United States' "Cinco de Mayo" due to its US Congress concurrent resolution status or Thailand's "Teachers' Day" as per gazetted back in 1956.

UNOFFICIAL would be those which are commonly celebrated by citizens of a particular jurisdiction but with no official observance - example of this would be Halloweens and Valentine's Day in the United States.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants