Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Aruba/Curaçao as NL subdivision #1852

Open
arkid15r opened this issue Jun 30, 2024 · 3 comments
Open

Refactor Aruba/Curaçao as NL subdivision #1852

arkid15r opened this issue Jun 30, 2024 · 3 comments

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Jun 30, 2024

Feature Request

Description

Make sure Aruba and Curaçao are available as a subdiv of Netherlands (based on https://www.iso.org/obp/ui/en/#iso:code:3166:AW and https://www.iso.org/obp/ui/en/#iso:code:3166:CW).

Related Issues

N/A

Proposed Solution

  • Move the AW and CW holidays logic to NL class.
  • Refactor Aruba logic to be based on NL's subdiv AW
  • Refactor Curaçao logic to be based on NL's subdiv CW

Additional context

N/A

@KJhellico
Copy link
Collaborator

It seems logical to do the same for Aruba.

@arkid15r arkid15r changed the title Refactor Curaçao as NL/CW subdivision Refactor Aruba/Curaçao as NL subdivision Jul 1, 2024
@arkid15r
Copy link
Collaborator Author

arkid15r commented Jul 1, 2024

It seems logical to do the same for Aruba.

Absolutely! I've updated the issue. Thanks!

@PPsyrius PPsyrius assigned PPsyrius and unassigned PPsyrius Aug 22, 2024
@PPsyrius
Copy link
Collaborator

PPsyrius commented Sep 5, 2024

Quick question here: Isle of Man, Jersey, and Guernsey were previously callable as Great Britain subdivisions before 2007: https://en.wikipedia.org/wiki/ISO_3166-2:GB as GB-IOM, GB-GSY, and GB-JSY respectively. Should these entities get the same treatment, too?

Ideally, we should have ways to call up the appropriate holiday codes rather than folding them into the main entities. That would be great here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants