Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit include_sundays param behavior #2177

Open
arkid15r opened this issue Dec 18, 2024 · 0 comments
Open

Revisit include_sundays param behavior #2177

arkid15r opened this issue Dec 18, 2024 · 0 comments
Labels

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Dec 18, 2024

At least from the perspective of my company, we are only interested in holidays other than Sundays (if we wanted Sundays we could very easily get them without this package). I find it confusing that Sundays are included for Sweden but not for other countries, because for all practical purposes, there is nothing special about Sundays in Sweden (apart from maybe some constitutional definition that bears no practical implication). Also, it caused a bug for us when Sundays coincided with other holidays and the name of the holiday changed, e.g. "Julafton; Söndag".

So regardless of if we want to use include_weekends or include_sundays, I think the default should be False to make it consistent with other countries. But then again, I don't know in which ways others use this package.

Based on #2072

Also related to #1654

@arkid15r arkid15r added the v1 label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant