Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Tooling changes #341

Closed
s-weigand opened this issue Jul 31, 2020 · 3 comments
Closed

[Question] Tooling changes #341

s-weigand opened this issue Jul 31, 2020 · 3 comments

Comments

@s-weigand
Copy link
Contributor

As promissed in https://github.com/dr-prodigy/python-holidays/issues/338#issuecomment-662592391 I'm working on a PR to change the CI from travis to github actions and also add CD.

Since you liked the idea of using bump2version, for releas process.
I was wondering if would also be interested in some other changes:

  • Autoformat code with black, so formatting code to look nice is a no brainer
  • Add pre-commit to run back and flake8 on commit, like that there won't be commits like fix flake8 which I saw a lot on other projects
  • Style check the tests with flake8, IMHO tests should also comply with styling rules
  • Use pytest as testrunner, pytest is more prowerful (and gives prettier output) than good old unittest and would also allow to restructure the tests to mimic the projects structure, which again would make it easier to find corresponding tests
  • Use tox so contributors can tests multiple python version locally
@s-weigand
Copy link
Contributor Author

s-weigand commented Aug 1, 2020

@mborsetti
Copy link
Contributor

This would be so nice!

@dr-prodigy
Copy link
Collaborator

We are on the way to release this soon.. Closing this question, thx! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants