You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since you liked the idea of using bump2version, for releas process.
I was wondering if would also be interested in some other changes:
Autoformat code with black, so formatting code to look nice is a no brainer
Add pre-commit to run back and flake8 on commit, like that there won't be commits like fix flake8 which I saw a lot on other projects
Style check the tests with flake8, IMHO tests should also comply with styling rules
Use pytest as testrunner, pytest is more prowerful (and gives prettier output) than good old unittest and would also allow to restructure the tests to mimic the projects structure, which again would make it easier to find corresponding tests
Use tox so contributors can tests multiple python version locally
The text was updated successfully, but these errors were encountered:
As promissed in https://github.com/dr-prodigy/python-holidays/issues/338#issuecomment-662592391 I'm working on a PR to change the CI from travis to github actions and also add CD.
Since you liked the idea of using
bump2version
, for releas process.I was wondering if would also be interested in some other changes:
black
, so formatting code to look nice is a no brainerpre-commit
to runback
andflake8
on commit, like that there won't be commits likefix flake8
which I saw a lot on other projectsflake8
, IMHO tests should also comply with styling rulespytest
as testrunner,pytest
is more prowerful (and gives prettier output) than good oldunittest
and would also allow to restructure the tests to mimic the projects structure, which again would make it easier to find corresponding teststox
so contributors can tests multiple python version locallyThe text was updated successfully, but these errors were encountered: