Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Waku 0: Mail Servers #36

Closed
decanus opened this issue Nov 18, 2019 · 6 comments
Closed

Waku 0: Mail Servers #36

decanus opened this issue Nov 18, 2019 · 6 comments
Assignees

Comments

@decanus
Copy link
Contributor

decanus commented Nov 18, 2019

Problem

Currently the Waku spec contains no mail server documentation, the implementation is not well specified enough.

Solution

Once there is some description of mailservers in status/spec, it should be added to the vac/specs.

Notes

@oskarth
Copy link
Contributor

oskarth commented Nov 20, 2019

There is a description in Status specs already. If this is blocked, we should be explicit about what exactly is missing.

https://github.com/status-im/specs/blob/master/status-whisper-mailserver-spec.md

@oskarth
Copy link
Contributor

oskarth commented Nov 21, 2019

Messages MAY be requested from mailservers by sending a packet with the p2pRequestCode code. Once received a mailserver SHOULD respond at some point in the future with packets containing the p2pMessageCode code.

There's a clear lack of format of the whisper envelope in p2prequest.

https://github.com/status-im/specs/blob/master/status-whisper-usage-spec.md#request-historic-messages this part isn't captured either

@oskarth
Copy link
Contributor

oskarth commented Nov 21, 2019

shh_markTrustedPeer and shhext_requestMessages are also at a different level than the current protocol codes, and this isn't captured in the spec...

@adambabik can you please help sort that spec out, it's been pending for a long time now. It can't refer to geth specific architecture, it needs to be at the wire level.

@adambabik
Copy link

PR fixing the current mailserver spec: status-im/specs#64

@oskarth
Copy link
Contributor

oskarth commented Dec 2, 2019

@decanus what's the state of this?

@decanus
Copy link
Contributor Author

decanus commented Dec 2, 2019

@oskarth imo we can close this: https://github.com/vacp2p/specs/blob/master/waku.md#mailserver-and-client the in spec stuff is up to date with latest in status specs.

@oskarth oskarth closed this as completed Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants