Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Waku 0: Describe existing rate limiting #40

Closed
1 task done
oskarth opened this issue Nov 20, 2019 · 2 comments · Fixed by #66
Closed
1 task done

Waku 0: Describe existing rate limiting #40

oskarth opened this issue Nov 20, 2019 · 2 comments · Fixed by #66
Assignees
@decanus

Comments

@oskarth
Copy link
Contributor

oskarth commented Nov 20, 2019 •
edited by decanus
Loading

Problem

Currently there's a rudimentary form of rate blocking. This is not captured in the spec, which makes it hard to write an implementation of it.

Acceptance criteria

  • Rate limiting captured in specs

Details

See status-im/specs#60 for current description

Possible Solutions

Document it based on above

Notes
@oskarth
Copy link
Contributor Author

oskarth commented Nov 20, 2019

Strictly speaking, currently rate limiting capability is not active. However, for v1 this is a blocker as identified by security audit.

Beyond a basic placeholder and rough text, this issue is blocked until status-im/specs#60 (comment) is further along.

@oskarth oskarth added the blocked This issue is blocked by some other work label Nov 20, 2019
@oskarth oskarth mentioned this issue Nov 20, 2019
Closed
11 tasks
@oskarth
Copy link
Contributor Author

oskarth commented Dec 5, 2019

This isn't blocked since status-im/specs#60 was merged

@oskarth oskarth removed the blocked This issue is blocked by some other work label Dec 5, 2019
@decanus decanus mentioned this issue Dec 5, 2019
Closed
17 tasks
@decanus decanus self-assigned this Dec 5, 2019
@decanus decanus mentioned this issue Dec 5, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@decanus decanus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spec/waku-rate-limiting vacp2p/rfc
2 participants
@oskarth @decanus