-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG-REPORT] Expression.astype("uint") works for numpy but not arrow #2191
Comments
Actually I do not thing this is a bug.. Look in at the arrow documentation there is not such thing as So in your test, if you use I guess we could make an alias for |
hmm, that makes sense why it doesn't work. If we were starting from scratch, I might actually lean the opposite way: Make If vaex is trying to be a higher level abstraction that hides the differences between numpy and arrow (I think this would be a great goal, but IDK how attainable it actually is) then I would like the alias proposal. However, if there are other cases where I DO need to know which is the backend for my data (eg #2192), then I would prefer if vaex explicitly left things as is and didn't try to do something clever. So IDK, I think it depends on the larger goals. I'm fine closing this as "not a bug" and just being more explicit in the docstring for |
I think we generally agree. I think the main idea (as much as we can make it) is that an average user should not care or even know whether the data lives in arrow or numpy underneath it all, as long as it is handled via vaex. When you get it out of vaex (like with And we do want most obvious things to work out of the box with safe general assumptions. I still think that many users are not so knowledgeable about (py)arrow yet.. so it is nice to have some higher abstraction. I am curious to hear @maartenbreddels opinion on this , so let's keep this open for now, and thanks for reporting! |
See added xfailing test: 538a5a6
The text was updated successfully, but these errors were encountered: