Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest lark-parser isn't compatible with commentjson #32

Closed
ianfhunter opened this issue Jan 22, 2020 · 6 comments
Closed

Latest lark-parser isn't compatible with commentjson #32

ianfhunter opened this issue Jan 22, 2020 · 6 comments

Comments

@ianfhunter
Copy link
Contributor

https://pypi.org/project/lark-parser/#history was released 32mins ago.

import commentjson as json
/home/testuser/.local/lib/python3.6/site-packages/commentjson/__init__.py:1: in <module>
    from .commentjson import dump
/home/testuser/.local/lib/python3.6/site-packages/commentjson/commentjson.py:55: in      <module>
    serializer = Reconstructor(parser)
/home/testuser/.local/lib/python3.6/site-packages/lark/reconstruct.py:92: in __init__
    assert parser.options.maybe_placeholders == False
@ianfhunter
Copy link
Contributor Author

ianfhunter commented Jan 22, 2020

Current work around for others affected - people can use my branch:
pip install git+https://github.com/ianfhunter/commentjson.git@patch-1

I will delete this after merged

@erezsh
Copy link

erezsh commented Jan 22, 2020

Sorry about that! I reverted the change in 0.8.1 (already released), and will use a major version for such a change next time.

@pkolbus
Copy link

pkolbus commented Jan 23, 2020

Hi @erezsh, what you did in lark-parser is correct according to SemVer, prior to 1.0.0 anything can change at any time as the API is explicitly unstable. It’s commentjson not constraining the dependency correctly.

That said, thanks for reverting, as that will help until commentjson can fix things.

@ianfhunter
Copy link
Contributor Author

No worries, Thanks for the revert :)

@vaidik
Copy link
Owner

vaidik commented Jan 23, 2020

On it folks. Reviewing the PR

@vaidik
Copy link
Owner

vaidik commented Jan 27, 2020

Hey guys

I have merged the PRs and cut a release - 0.8.3.

@ianfhunter thanks a lot for the patch! Really appreciate it!

@vaidik vaidik closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants