Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: support for JUnit5 #12

Closed
Danman85 opened this issue Mar 6, 2023 · 6 comments
Closed

Request: support for JUnit5 #12

Danman85 opened this issue Mar 6, 2023 · 6 comments

Comments

@Danman85
Copy link

Danman85 commented Mar 6, 2023

Hello,

I installed the plugin recently and enjoying it, except for the fact that JUnit5 is not supported:

8:36:55 AM PIT >> INFO : Verbose logging is disabled. If you encounter a problem, please enable it before reporting an issue.
8:36:56 AM PIT >> WARNING : JUnit 5 is on the classpath but the pitest junit 5 plugin is not installed (https://github.com/pitest/pitest-junit5-plugin)
8:36:57 AM PIT >> INFO : Incremental analysis reduced number of mutations by 0
8:36:57 AM PIT >> INFO : Created 1 mutation test units in pre scan
8:36:58 AM PIT >> INFO : Sending 1 test classes to minion
8:36:58 AM PIT >> INFO : Sent tests to minion
8:36:58 AM PIT >> INFO : Calculated coverage in 1 seconds.
8:36:59 AM PIT >> INFO : Incremental analysis reduced number of mutations by 0
8:36:59 AM PIT >> INFO : Created 1 mutation test units
/================================================================================
8:36:59 AM PIT >> INFO : Completed in 3 seconds

Could you add support for that?

Thanks in advance.

@fhuesig
Copy link
Collaborator

fhuesig commented May 3, 2023

Hello,
so i took a look at it and tried to integrate it into the project. I added the pitest-junit5-plugin and the jupiter and vintage engine. But the tests dont have any line coverage in the reports anymore. I tried to update the option --testPlugin to junit5 like in the gradle/maven version explained, but that didnt do the trick. I doublechecked and the option --testPlugin is not changeable in the command line so it always defaults to junit. So at this point i can not integrate junit5. I will contact Henry from pitest and maybe he got a solution. So i might get back to you in a few days

@fhuesig
Copy link
Collaborator

fhuesig commented May 3, 2023

i opened a new issue here until then we have to wait:

pitest/pitest-junit5-plugin#80

@fhuesig
Copy link
Collaborator

fhuesig commented May 8, 2023

maybe its just command line related so i opened here an issue as well hcoles/pitest#1196

@fhuesig
Copy link
Collaborator

fhuesig commented Jun 5, 2023

I got some feedback on the ticket but it seems it still doesnt work correctly. I am still on it and will let you know as soon as i got some news.

@fhuesig
Copy link
Collaborator

fhuesig commented Jun 7, 2023

Hi,
so i got a response on the pitest ticket from Henry. It was not quite the solution i was looking for but it was a big helpful step. So i figured out the solution and could successfully integrate junit5 into the plugin. In Intellij it will be available in the next 24hours. Otherwise its also in this github as release 1.4.0

@fhuesig fhuesig closed this as completed Jun 7, 2023
@Danman85
Copy link
Author

@fhuesig thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants