Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stable rust #71

Closed
tglman opened this issue Feb 21, 2021 · 3 comments
Closed

Support for stable rust #71

tglman opened this issue Feb 21, 2021 · 3 comments

Comments

@tglman
Copy link
Contributor

tglman commented Feb 21, 2021

Hi,

To build and run vigil is required nigthly rust, in many case this is fine but in some stable rust is required.
I did my own investigation, and the only reason why nighlty is required is for some compiler features that rocket requires, this should be fixed the next releases of rocket as the master of rocket is already compatible with stable rust: rwf2/Rocket#19 (comment) but this as today is yet not a good option, simply because this is not releases yet.

So i went a bit ahead and made a quick fork (here) that make rocket optional, and then i did a server implementation using actix-web, that as i write it already run in rust stable (you can see the implementation here).

What it's your take on this issue ? do you prefer wait for rocket to be stable ? do you like to have two possible server implementations? or maybe migrate to actix-web is already stable ?

Regards

@valeriansaliou
Copy link
Owner

Hello @tglman

Thanks a ton for your work on migrating from Rocket to Actix! I was indeed waiting for Rocket to compile on stable, but this takes a bit of time, so I'm willing to fully migrate to Actix.

You may completely remove Rocket in your fork, and submit a PR, I'll greatly appreciate it 👍

Thanks again!

@tglman
Copy link
Contributor Author

tglman commented Feb 22, 2021

Hi,

Here the PR with rocket that is replaced by actix-web: #72

Regards

@valeriansaliou
Copy link
Owner

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants