Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Docker Compose environments? #88

Closed
ultimike opened this issue Feb 15, 2023 · 6 comments
Closed

Support Docker Compose environments? #88

ultimike opened this issue Feb 15, 2023 · 6 comments

Comments

@ultimike
Copy link

I have all my environments in docker machines, and I'd like to configure phpsab.executablePathCS and phpsab.executablePathCBF` to run in the container. Something like

docker-compose exec php vendor/bin/phpcs path/to/files/to/lint

I'd rather not run phpcs from my host operating systems.

I was hoping to do something like this, but I cannot get it working. Is this possible?

-mike

@ultimike ultimike changed the title Support Docker Composer environments? Support Docker Compose environments? Feb 15, 2023
@mreduar
Copy link

mreduar commented Mar 20, 2023

Any update?

@shaneparsons
Copy link

Yeah, this would be great to have!

SanderRonde/phpstan-vscode has a great implementation of this with their phpstan.binCommand config option. Would be great to have something similar here.

@shaneparsons
Copy link

This fork of this repo appears to work well actually https://github.com/mtbdata711/vscode-phpsab-docker. Probably just a matter of somebody opening a pull request to merge the changes into here.

@valeryan
Copy link
Owner

Yeah, I don't have time to actively work on this project these days and I work in .net now. I will always field PRs though.

@jonathanbossenger
Copy link
Collaborator

@valeryan perhaps it would make sense to update the readme to include details on the fork that works with docker, and then you could close this ticket?

Happy to submit a pr to update the readme.

@valeryan
Copy link
Owner

Information about how to find the docker fork was added to the readme. Closing this. If the developer of that fork wants to look at a way to add docker support to the main extension through PR I will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants