Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Ability to ignore CVEs #62

Open
mattwelke opened this issue Jul 10, 2024 · 3 comments · May be fixed by #65
Open

✨ Ability to ignore CVEs #62

mattwelke opened this issue Jul 10, 2024 · 3 comments · May be fixed by #65
Assignees
@wcrum
Labels
new-feature Net-new feature

Comments

@mattwelke
Copy link
Member

mattwelke commented Jul 10, 2024 •
edited
Loading

Summary

The ability to ignore detected CVEs was previously partially implemented. During a refactor, we found that ignoredCVEs in the rule's reconcile method was unused.

This feature can be fully implemented later. The partially implemented feature used this in the spec, which can be used for reference:

// Global Ignore CVEs
IgnoredCVERule []string `json:"ignoredCVERule,omitempty" yaml:"ignoredCVERule,omitempty"`
@TylerGillson
Copy link
Member

@mattwelke IMO this issue is not actionable. Can you please define what you'd consider to be a full implementation? What is missing? What are the acceptance criteria?

@TylerGillson
Copy link
Member

Ok - now I've found the context in #63

@TylerGillson
Copy link
Member

@wcrum can you please address this?

@wcrum wcrum linked a pull request Jul 11, 2024 that will close this issue
Open
@TylerGillson TylerGillson added the new-feature Net-new feature label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wcrum wcrum

Labels
new-feature Net-new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add global ignore cve and multi function rule validator-labs/validator-plugin-kubescape
3 participants
@TylerGillson @mattwelke @wcrum