fix: ensure unique condition.ValidationRule names across different rule types #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
mattwelke
previously approved these changes
Oct 3, 2024
mattwelke
approved these changes
Oct 3, 2024
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 39.48% 39.55% +0.07%
==========================================
Files 32 32
Lines 2001 2005 +4
==========================================
+ Hits 790 793 +3
- Misses 1111 1112 +1
Partials 100 100
Continue to review full report in Codecov by Sentry.
|
ahmad-ibra
pushed a commit
that referenced
this pull request
Oct 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.4](v0.1.3...v0.1.4) (2024-10-03) ### Bug Fixes * ensure unique condition.ValidationRule names across different rule types ([#377](#377)) ([2a6f5ab](2a6f5ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #376
Description
This PR ensures that the validation rule type is a part of the validation results rule name.