Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Remove KubectlCommand function and use a k8s client instead #8

Open
ahmad-ibra opened this issue Jun 11, 2024 · 0 comments
Open

🎨 Remove KubectlCommand function and use a k8s client instead #8

ahmad-ibra opened this issue Jun 11, 2024 · 0 comments
Labels
good-first-issue Good for newcomers refactoring Refactoring / tech debt

Comments

@ahmad-ibra
Copy link
Collaborator

Description

While the KubectlCommand function works, we shouldnt be directly invoking kubectl shell commands within validatorctl. Instead we should rework this so that we use a k8s client anywhere that the KubectlCommand function was invoked.

AC

  • the validatorctl no longer invokes kubectl shell commands
@TylerGillson TylerGillson changed the title Remove KubectlCommand function and use a k8s client instead 🎨 Remove KubectlCommand function and use a k8s client instead Jun 11, 2024
@TylerGillson TylerGillson added the refactoring Refactoring / tech debt label Jun 11, 2024
@TylerGillson TylerGillson added the good-first-issue Good for newcomers label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers refactoring Refactoring / tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerGillson @ahmad-ibra