Cleanup some files in node, modernize tests, and update the node matrix (#3928)

* Update supported language versions, refine .gitignore, and enhance Jest configuration

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Enhance comments in setup.ts to clarify the purpose of clearing timers after tests

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

Author: avifenesh

.github/json_matrices/supported-languages-versions.json

@@ -11,8 +11,8 @@
     },
     {
         "language": "node",
-        "versions": ["16.x", "18.x", "20.x", "22.x", "23.x"],
-        "always-run-versions": ["18.x", "22.x"]
+        "versions": ["16.x", "20.x", "22.x", "23.x"],
+        "always-run-versions": ["20.x", "23.x"]
     },
     {
         "language": "dotnet",

.gitignore

@@ -62,6 +62,7 @@ docs/markdown/node/**
 docs/site/**
 copilot.yml
 memory-bank/
+CLAUDE*
 #cpp files
 cpp/benchmarks/build/
 cpp/build/
@@ -70,3 +71,7 @@ cpp/include/glide/connection_request.pb.h
 
 cpp/include/glide/glide_base.h
 cpp/src/connection_request.pb.cc
+
+**/.claude/settings.local.json
+copilot-instructions.md
+**/.yarn

.gitmodules

@@ -7,7 +7,7 @@ export default tseslint.config(
     eslint.configs.recommended,
     ...tseslint.configs.recommended,
     ...tseslint.configs.stylistic,
-    { files: [ "**/*.js" ], ...tseslint.configs.disableTypeChecked },
+    { files: ["**/*.js"], ...tseslint.configs.disableTypeChecked },
     {
         ignores: [
             "*/ProtobufMessage.*",
@@ -63,10 +63,10 @@ export default tseslint.config(
                     ObjectExpression: 1,
                     FunctionDeclaration: { parameters: "first" },
                     FunctionExpression: { parameters: "first" },
-                    ignoredNodes: [ "TSTypeParameterInstantiation" ],
+                    ignoredNodes: ["TSTypeParameterInstantiation"],
                 },
             ],
         },
     },
-    prettierConfig
+    prettierConfig,
 );

eslint.config.mjs

@@ -30,28 +30,13 @@ coverage
 # nyc test coverage
 .nyc_output
 
-# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
-.grunt
-
-# Bower dependency directory (https://bower.io/)
-bower_components
-
-# node-waf configuration
-.lock-wscript
-
 # Compiled binary addons (https://nodejs.org/api/addons.html)
 build/Release
 
 # Dependency directories
 node_modules/
 jspm_packages/
 
-# Snowpack dependency directory (https://snowpack.dev/)
-web_modules/
-
-# TypeScript cache
-*.tsbuildinfo
-
 # Optional npm cache directory
 .npm
 
@@ -60,13 +45,6 @@ web_modules/
 
 # Optional stylelint cache
 .stylelintcache
-
-# Microbundle cache
-.rpt2_cache/
-.rts2_cache_cjs/
-.rts2_cache_es/
-.rts2_cache_umd/
-
 # Optional REPL history
 .node_repl_history
 
@@ -83,42 +61,13 @@ web_modules/
 .env.production.local
 .env.local
 
-# parcel-bundler cache (https://parceljs.org/)
-.cache
-.parcel-cache
 
 # Next.js build output
 .next
 out
 
-# Nuxt.js build / generate output
-.nuxt
-dist
 
-# Gatsby files
-.cache/
-# Comment in the public line in if your project uses Gatsby and not Next.js
-# https://nextjs.org/blog/next-9-1#public-directory-support
-# public
-
-# vuepress build output
-.vuepress/dist
-
-# vuepress v2.x temp and cache directory
-.temp
-.cache
-
-# Docusaurus cache and generated files
-.docusaurus
-
-# Serverless directories
-.serverless/
-
-# FuseBox cache
-.fusebox/
-
-# DynamoDB Local files
-.dynamodb/
+dist/
 
 # TernJS port file
 .tern-port
@@ -138,7 +87,12 @@ yarn.lock
 
 # Protobuf
 src/ProtobufMessage*
+proto/
 
 .npmignore
 
 package.json.tmpl
+
+native.js
+native.d.ts
+native.js.map

node/.gitignore

@@ -8,16 +8,19 @@ const config: Config = {
     transformIgnorePatterns: [
         "node_modules/",
         "\\.(js|jsx)$",
-        "<rootDir>/build-js/",
+        "<rootDir>/build-ts/",
     ],
     testEnvironment: "node",
+    // Look for tests inside the /tests/ directory with .test or .spec extensions
     testRegex: "/tests/.*\\.(test|spec)?\\.(ts|tsx)$",
-    moduleFileExtensions: ["ts", "json", "node", "js"],
-    modulePathIgnorePatterns: ["rust-client/"],
+    moduleFileExtensions: ["ts", "js", "json", "node"],
+    modulePathIgnorePatterns: ["rust-client/", "build-js/"],
+
+    // Reporters: default + HTML report
     reporters: [
         "default",
         [
-            "./node_modules/jest-html-reporter",
+            "jest-html-reporter",
             {
                 includeFailureMsg: true,
                 includeSuiteFailure: true,
@@ -26,7 +29,11 @@ const config: Config = {
             },
         ],
     ],
-    setupFilesAfterEnv: ["./tests/setup.ts"],
+
+    // Setup file to configure the testing environment after Jest is installed
+    setupFilesAfterEnv: ["<rootDir>/tests/setup.ts"],
+
+    // Coverage settings
     coverageProvider: "v8",
     collectCoverage: true,
     coverageReporters: ["text", "html"],

node/jest.config.ts

@@ -1,5 +1,6 @@
 /* eslint-disable no-var */
-import { beforeAll } from "@jest/globals";
+/// <reference types="jest" />
+import { afterEach, beforeAll } from "@jest/globals";
 import minimist from "minimist";
 import { Logger } from "../build-ts";
 
@@ -8,6 +9,12 @@ beforeAll(() => {
     // Logger.setLoggerConfig("off");
 });
 
+// Clear all timers after each test to prevent hanging handles,
+// Hanging handles are often caused by setTimeout, setInterval, or similar functions that are not cleared properly. Meaning we create a timer which something is waiting for it to finish, whether the test or some code piece, and not clearing it led to the test hanging. Causing memory leaks and other issues.
+afterEach(() => {
+    jest.clearAllTimers();
+});
+
 declare global {
     var CLI_ARGS: Record<string, string | boolean | number>;
     var CLUSTER_ENDPOINTS: string;

node/npm/glide/jest.config.js

@@ -12,13 +12,13 @@
     "author": "",
     "license": "Apache-2.0",
     "devDependencies": {
-        "@types/node": "22.9",
-        "@types/semver": "^7.5.8",
-        "prettier": "^3.3"
+        "@types/node": "22",
+        "@types/semver": "^7",
+        "prettier": "^3"
     },
     "dependencies": {
-        "child_process": "^1.0.2",
-        "semver": "^7.6.3",
-        "typescript": "^5.4.5"
+        "child_process": "^1",
+        "semver": "^7",
+        "typescript": "^5"
     }
 }

node/tests/setup.ts

@@ -6,16 +6,17 @@
     "type": "module",
     "scripts": {
         "test": "node index.js",
-        "build-utils": "cd ../../ && npm run build",
+        "build:utils": "cd ../../ && npm install && npm run build",
         "prettier:check:ci": "./node_modules/.bin/prettier --check .",
         "prettier:format": "./node_modules/.bin/prettier --write . "
     },
     "author": "",
     "license": "Apache-2.0",
     "dependencies": {
-        "@valkey/valkey-glide": "latest"
+        "@valkey/valkey-glide": "latest",
+        "typescript": "^5"
     },
     "devDependencies": {
-        "prettier": "^2.8.8"
+        "prettier": "^3"
     }
 }