Refactored select command to route to all nodes per default

Removed the option to provide a route

Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>

Author: affonsov

java/client/src/main/java/glide/api/GlideClusterClient.java

@@ -41,6 +41,7 @@
 import static glide.api.models.commands.function.FunctionListOptions.LIBRARY_NAME_VALKEY_API;
 import static glide.api.models.commands.function.FunctionListOptions.WITH_CODE_VALKEY_API;
 import static glide.api.models.commands.function.FunctionLoadOptions.REPLACE;
+import static glide.api.models.configuration.RequestRoutingConfiguration.SimpleMultiNodeRoute.ALL_NODES;
 import static glide.utils.ArrayTransformUtils.castArray;
 import static glide.utils.ArrayTransformUtils.castMapOfArrays;
 import static glide.utils.ArrayTransformUtils.concatenateArrays;
@@ -471,21 +472,12 @@ public CompletableFuture<ClusterValue<GlideString>> echo(
     }
 
     @Override
-    public CompletableFuture<String> select(long index) {
-        return commandManager.submitNewCommand(
-                Select, new String[] {Long.toString(index)}, this::handleStringResponse);
-    }
-
-    @Override
-    public CompletableFuture<ClusterValue<String>> select(long index, @NonNull Route route) {
+    public CompletableFuture<ClusterValue<String>> select(long index) {
         return commandManager.submitNewCommand(
                 Select,
                 new String[] {Long.toString(index)},
-                route,
-                response ->
-                        route instanceof SingleNodeRoute
-                                ? ClusterValue.ofSingleValue(handleStringResponse(response))
-                                : ClusterValue.ofMultiValue(handleMapResponse(response)));
+                ALL_NODES,
+                response -> ClusterValue.ofMultiValue(handleMapResponse(response)));
     }
 
     @Override

java/client/src/main/java/glide/api/commands/ConnectionManagementClusterCommands.java

@@ -250,39 +250,6 @@ public interface ConnectionManagementClusterCommands {
      */
     CompletableFuture<ClusterValue<GlideString>> echo(GlideString message, Route route);
 
-    /**
-     * Changes the currently selected database on cluster nodes.<br>
-     * The command will be routed to all nodes.
-     *
-     * <p><b>WARNING:</b> This command is <b>NOT RECOMMENDED</b> for production use. Upon
-     * reconnection, nodes will revert to the database_id specified in the client configuration
-     * (default: 0), NOT the database selected via this command.
-     *
-     * <p><b>RECOMMENDED APPROACH:</b> Use the database_id parameter in client configuration instead:
-     *
-     * <pre>{@code
-     * GlideClusterClient client = GlideClusterClient.createClient(
-     *     GlideClusterClientConfiguration.builder()
-     *         .address(NodeAddress.builder().host("localhost").port(6379).build())
-     *         .databaseId(5)  // Recommended: persists across reconnections
-     *         .build()
-     * ).get();
-     * }</pre>
-     *
-     * <p><b>CLUSTER BEHAVIOR:</b> This command routes to all nodes by default to maintain consistency
-     * across the cluster.
-     *
-     * @see <a href="https://valkey.io/commands/select/">valkey.io</a> for details.
-     * @param index The index of the database to select.
-     * @return A simple <code>OK</code> response.
-     * @example
-     *     <pre>{@code
-     * String response = clusterClient.select(0).get();
-     * assert response.equals("OK");
-     * }</pre>
-     */
-    CompletableFuture<String> select(long index);
-
     /**
      * Changes the currently selected database on cluster nodes.
      *
@@ -305,7 +272,7 @@ public interface ConnectionManagementClusterCommands {
      * @example
      *     <pre>{@code
      * // Command sent to all nodes via ALL_NODES route, expecting a MultiValue result.
-     * Map<String, String> responsePerNode = clusterClient.select(5, ALL_NODES).get().getMultiValue();
+     * Map<String, String> responsePerNode = clusterClient.select(5).get().getMultiValue();
      * for(var response : responsePerNode.values()) {
      *     assert response.equals("OK");
      * }
@@ -315,5 +282,5 @@ public interface ConnectionManagementClusterCommands {
      * assert response.equals("OK");
      * }</pre>
      */
-    CompletableFuture<ClusterValue<String>> select(long index, Route route);
+    CompletableFuture<ClusterValue<String>> select(long index);
 }

java/integTest/src/test/java/glide/SharedCommandTests.java

@@ -18,7 +18,6 @@
 import static glide.api.models.commands.SetOptions.Expiry.Milliseconds;
 import static glide.api.models.commands.SortBaseOptions.OrderBy.ASC;
 import static glide.api.models.commands.SortBaseOptions.OrderBy.DESC;
-import static glide.api.models.configuration.RequestRoutingConfiguration.SimpleMultiNodeRoute.ALL_NODES;
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -117,7 +116,6 @@
 import glide.api.models.commands.stream.StreamTrimOptions.MinId;
 import glide.api.models.configuration.ProtocolVersion;
 import glide.api.models.exceptions.RequestException;
-import glide.cluster.ValkeyCluster;
 import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -17620,54 +17618,6 @@ private static boolean isServerVersionAtLeast9_0() {
         return SERVER_VERSION.isGreaterThanOrEqualTo("9.0.0");
     }
 
-    @SneakyThrows
-    private ValkeyCluster createDedicatedCluster(boolean clusterMode) {
-        return new ValkeyCluster(false, clusterMode, clusterMode ? 3 : 1, 0, null, null);
-    }
-
-    @SneakyThrows
-    @ParameterizedTest(autoCloseArguments = false)
-    @MethodSource("getClients")
-    public void select_command_standalone(BaseClient client) {
-        // Only test SELECT on standalone clients
-        if (client instanceof GlideClusterClient) {
-            return; // Skip cluster clients for this test
-        }
-
-        GlideClient standaloneClient = (GlideClient) client;
-        String key1 = UUID.randomUUID().toString();
-        String key2 = UUID.randomUUID().toString();
-
-        // Start in database 0, set a value
-        assertEquals(OK, standaloneClient.set(key1, "value_db0").get());
-        assertEquals("value_db0", standaloneClient.get(key1).get());
-
-        // Switch to database 1
-        assertEquals(OK, standaloneClient.select(1).get());
-
-        // Key from DB 0 should not exist in DB 1
-        assertEquals(null, standaloneClient.get(key1).get());
-
-        // Set a value in database 1
-        assertEquals(OK, standaloneClient.set(key2, "value_db1").get());
-        assertEquals("value_db1", standaloneClient.get(key2).get());
-
-        // Switch back to database 0
-        assertEquals(OK, standaloneClient.select(0).get());
-
-        // Original key should still exist in DB 0
-        assertEquals("value_db0", standaloneClient.get(key1).get());
-
-        // Key from DB 1 should not exist in DB 0
-        assertEquals(null, standaloneClient.get(key2).get());
-
-        // Clean up
-        assertEquals(1L, standaloneClient.del(new String[] {key1}).get());
-        assertEquals(OK, standaloneClient.select(1).get());
-        assertEquals(1L, standaloneClient.del(new String[] {key2}).get());
-        assertEquals(OK, standaloneClient.select(0).get()); // Reset to DB 0
-    }
-
     @SneakyThrows
     @ParameterizedTest(autoCloseArguments = false)
     @MethodSource("getClients")
@@ -17683,52 +17633,27 @@ public void select_command_cluster_basic_functionality(BaseClient client) {
         GlideClusterClient clusterClient = (GlideClusterClient) client;
         String key = UUID.randomUUID().toString();
 
-        // Test that SELECT command returns OK
-        String selectResult = clusterClient.select(1).get();
-        assertEquals(OK, selectResult);
+        // Switch to database 1 with explicit ALL_NODES routing
+        ClusterValue<String> selectResult = clusterClient.select(1).get();
+        // When routing to ALL_NODES, we get a multi-value result
+        for (String result : selectResult.getMultiValue().values()) {
+            assertEquals(OK, result);
+        }
 
         // Test that we can perform operations after SELECT
         assertEquals(OK, clusterClient.set(key, "test_value").get());
         assertEquals("test_value", clusterClient.get(key).get());
 
-        // Switch back to database 0
+        // Switch to database 0 with explicit ALL_NODES routing
         selectResult = clusterClient.select(0).get();
-        assertEquals(OK, selectResult);
-
-        // Clean up
-        clusterClient.select(1).get();
-        clusterClient.del(new String[] {key}).get();
-        clusterClient.select(0).get(); // Reset to DB 0
-    }
-
-    @SneakyThrows
-    @ParameterizedTest(autoCloseArguments = false)
-    @MethodSource("getClients")
-    @EnabledIf("isServerVersionAtLeast9_0")
-    public void select_command_cluster_with_explicit_routing(BaseClient client) {
-        // Only test SELECT on cluster clients with Valkey 9.0+
-        if (!(client instanceof GlideClusterClient)) {
-            return; // Skip standalone clients for this test
-        }
-
-        assumeTrue(isServerVersionAtLeast9_0(), "Multi-DB cluster mode requires Valkey 9.0+");
-
-        GlideClusterClient clusterClient = (GlideClusterClient) client;
-        String key = UUID.randomUUID().toString();
-
-        // Switch to database 2 with explicit ALL_NODES routing
-        ClusterValue<String> selectResult = clusterClient.select(2, ALL_NODES).get();
         // When routing to ALL_NODES, we get a multi-value result
         for (String result : selectResult.getMultiValue().values()) {
             assertEquals(OK, result);
         }
 
-        // Verify we're in database 2 by setting and getting a value
-        assertEquals(OK, clusterClient.set(key, "value_db2").get());
-        assertEquals("value_db2", clusterClient.get(key).get());
-
         // Clean up
-        assertEquals(1L, clusterClient.del(new String[] {key}).get());
+        clusterClient.select(1).get();
+        clusterClient.del(new String[] {key}).get();
         clusterClient.select(0).get(); // Reset to DB 0
     }
 
@@ -17755,32 +17680,4 @@ public void select_command_invalid_database_standalone(BaseClient client, int in
                 exception.getMessage().toLowerCase().contains("invalid")
                         || exception.getMessage().toLowerCase().contains("out of range"));
     }
-
-    @SneakyThrows
-    @ParameterizedTest(autoCloseArguments = false)
-    @MethodSource("getClients")
-    public void select_command_cluster_on_older_server(BaseClient client) {
-        // Only test SELECT on cluster clients on older servers
-        if (!(client instanceof GlideClusterClient)) {
-            return; // Skip standalone clients for this test
-        }
-
-        if (isServerVersionAtLeast9_0()) {
-            assumeTrue(false, "Skipping test on Valkey 9.0+ where multi-DB cluster is supported");
-        }
-
-        GlideClusterClient clusterClient = (GlideClusterClient) client;
-
-        ExecutionException exception =
-                assertThrows(
-                        ExecutionException.class,
-                        () -> {
-                            clusterClient.select(1).get();
-                        });
-
-        assertTrue(
-                exception.getMessage().toLowerCase().contains("select")
-                        || exception.getMessage().toLowerCase().contains("cluster")
-                        || exception.getMessage().toLowerCase().contains("not allowed"));
-    }
 }