Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local downloads not working on Windows #84

Open
JuhaKiili opened this issue Feb 21, 2022 · 1 comment
Open

Local downloads not working on Windows #84

JuhaKiili opened this issue Feb 21, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@JuhaKiili
Copy link
Contributor

JuhaKiili commented Feb 21, 2022

If you have this code

import valohai
valohai.prepare(step="train", default_inputs={"test": "https://upload.wikimedia.org/wikipedia/en/a/a9/Example.jpg"})
print(valohai.inputs("test").path())

And run it in Windows, you get a path like:

.valohai/inputs\\test\\example.jpg

The consts.py hardcodes the POSIX path separator, which doesn't work on Windows. Need to fix that.

@akx
Copy link
Member

akx commented Feb 21, 2022

It should work just fine, though – Python's path manipulation bits internally convert slashes to the platform-native direction.

@akx akx added the bug Something isn't working label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants