Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundle): to UMD format #1098

Closed
wants to merge 5 commits into from
Closed

feat(bundle): to UMD format #1098

wants to merge 5 commits into from

Conversation

lifaon74
Copy link

@lifaon74 lifaon74 commented Oct 7, 2016

Quick fix from #1093

Valentin Richard added 2 commits October 7, 2016 14:25
@lifaon74
Copy link
Author

lifaon74 commented Oct 7, 2016

I inline source maps because I let developpers to minimize by themself files (and removing comments). It avoids to have too many files. You can change it as your conveniance.

@valorkin
Copy link
Member

valorkin commented Oct 7, 2016

Without this key mouse events, universal is not working :)

@valorkin valorkin changed the title AoT for ng2-boostrap feat(bundle): to UMD format Oct 11, 2016
@valorkin
Copy link
Member

can you leave here only .npmignore and make.js files?
and revert all other changes?

@lifaon74
Copy link
Author

Done

@valorkin
Copy link
Member

Please check that AoT works fine,
I will play with this one :)
Thanks for quick reaction

@lifaon74
Copy link
Author

lifaon74 commented Oct 11, 2016

My bad, i forgot to rollback some files

@valorkin
Copy link
Member

ok, thing is
If I am planning to roll out this one
everybody will have to, replace
import 'ng2-bootstrap\ng2-bootstrap' to import 'ng2-bootstrap'
what is actually an artifact from ng2 alfas

@valorkin
Copy link
Member

ok, testing with system.js and ng-cli (webpack)

@valorkin
Copy link
Member

ng-cli: normal and AoT versions both imports working fine ;)

@valorkin valorkin closed this in a7554a8 Oct 11, 2016
@valorkin
Copy link
Member

released as @beta,
check plunker and angular2-quickstart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants