Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use typescript 1.8 #116

Closed
binarious opened this issue Feb 1, 2016 · 10 comments
Closed

chore(deps): use typescript 1.8 #116

binarious opened this issue Feb 1, 2016 · 10 comments

Comments

@binarious
Copy link

update: blocked by angular/angular#6468

When building my app with webpack I get:

ERROR in ./~/ng2-bootstrap/components/timepicker/timepicker.ts
(112,5): error TS7027: Unreachable code detected.

Seems legit, because there is an if (true) with a return and code after that:
https://github.com/valor-software/ng2-bootstrap/blob/802c64f65b42ca8f9b6d5a184f229c19934ecbb6/components/timepicker/timepicker.component.ts#L103

@valorkin
Copy link
Member

valorkin commented Feb 1, 2016

You using ts 1.8 :)

@binarious
Copy link
Author

Whoops possible. Is 1.8 not yet supported?

@valorkin
Copy link
Member

valorkin commented Feb 1, 2016

Is it out of beta?

@valorkin
Copy link
Member

valorkin commented Feb 1, 2016

I am really waiting for it, it may simplify system js bundling

@binarious
Copy link
Author

No it's not out of beta: https://github.com/Microsoft/TypeScript/releases
Shall I leave this issue open? Since the problem will occur in the future.

@valorkin valorkin changed the title Unreachable code in timepicker chore(deps): use typescript 1.8 Feb 1, 2016
@valorkin
Copy link
Member

valorkin commented Feb 1, 2016

updated description to contain angular blocker issue angular/angular#6468

@binarious
Copy link
Author

fyi: blocker issue closed.

@valorkin
Copy link
Member

Yeap, I know. But not available until Monday, in trip right now

@binarious
Copy link
Author

All good. Have a nice trip ;-).

@valorkin
Copy link
Member

Thanks, when I am back, I will be updating all the things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants