Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert 2 emits when dismissOnTimeout and dismissible if dismissed before time out #1430

Closed
dafreaki opened this issue Jan 3, 2017 · 0 comments

Comments

@dafreaki
Copy link

dafreaki commented Jan 3, 2017

in alert.component.ts
caused by this as it fires after a onClose has been called by the dismiss (click)="onClose()"
if (this.dismissOnTimeout) {
setTimeout(() => this.onClose(), this.dismissOnTimeout);
}

fix would be something like the following to stop the emit being sent if the alert has been closed already

onClose() {
if (!this.closed){
this.closed = true;
this.close.emit(this);
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant