Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RC6 #906

Closed
isaackehle opened this issue Sep 1, 2016 · 15 comments
Closed

Support for RC6 #906

isaackehle opened this issue Sep 1, 2016 · 15 comments

Comments

@isaackehle
Copy link

I just upgraded to RC6, and now webpack is giving errors:

[default] /Users/pgkehle/projects/security-portal/node_modules/ng2-bootstrap/components/datepicker/datepicker-popup.component.d.ts:1:10
    Module '"/Users/pgkehle/projects/security-portal/node_modules/@angular/core/index"' has no exported member 'DynamicComponentLoader'.
[default] /Users/pgkehle/projects/security-portal/node_modules/ng2-bootstrap/components/tooltip/tooltip.directive.d.ts:1:10
    Module '"/Users/pgkehle/projects/security-portal/node_modules/@angular/core/index"' has no exported member 'DynamicComponentLoader'.
[default] /Users/pgkehle/projects/security-portal/node_modules/ng2-bootstrap/components/typeahead/typeahead.directive.d.ts:1:54
    Module '"/Users/pgkehle/projects/security-portal/node_modules/@angular/core/index"' has no exported member 'DynamicComponentLoader'.
[default] /Users/pgkehle/projects/security-portal/node_modules/ng2-bootstrap/components/utils/components-helper.service.d.ts:1:58
    Module '"/Users/pgkehle/projects/security-portal/node_modules/@angular/core/index"' has no exported member 'ComponentResolver'.
[default] /Users/pgkehle/projects/security-portal/node_modules/ng2-bootstrap/components/utils/components-helper.service.d.ts:42:32
    Generic type 'Type<T>' requires 1 type argument(s).

From here: http://stackoverflow.com/questions/38332249/angular-2-rc4-dynamiccomponentloader-deprecated

ComponentResolver and ViewContainerRef are alternatives.

@glaucomorais
Copy link

Same thing here.
Every @Component usage is getting the"@angular/core/index" has no exported member 'ComponentResolver' error message.

@spock123
Copy link

spock123 commented Sep 1, 2016

Yeah, according to the changelog for RC6, https://github.com/angular/angular/blob/master/CHANGELOG.md, ComponentResolver is deprecated.

core: deprecated ComponentResolver was removed. Please use ComponentFactoryResolver instead.

@spock123
Copy link

spock123 commented Sep 1, 2016

Also:

core: Type is now Type<T> which means that in most cases you have to use Type<any> in place of Type.

@spock123
Copy link

spock123 commented Sep 1, 2016

Seems ng2-bootstrap 1.1 is out, with upgrades to RC6.. let's give it a try

Thank you so much for all your hard work, guys
update: sorry, no 1.1.0 is for RC5.

@Martin-Luft
Copy link
Contributor

@valorkin can you please publish a new npm release 1.1.1 (1.1.0 is RC5)? But before please merge PR #909

@elirenato
Copy link

elirenato commented Sep 1, 2016

also waiting for npm release 1.1.1 to support RC6 :)

@sprypradeep
Copy link

Need to make changes to components-helper.service.d.ts

core: merge Type and ConcreteType into Type (#10616) (b96869a), closes #9729

angular/angular#10616

@elirenato
Copy link

elirenato commented Sep 1, 2016

just to complement @sprypradeep.

I get the error below when using angular-rc6 with ng2-bootstrap 1.1.0:

.../node_modules/ng2-bootstrap/components/utils/components-helper.service.d.ts(2,10): error TS2305: Module '".../node_modules/@angular/core/src/facade/lang"' has no exported member 'ConcreteType'.

@Martin-Luft
Copy link
Contributor

@sprypradeep this is already fixed in master. We must wait until @valorkin merged the PR #909 and created a new npm release (1.1.1). I hope he will do it tomorrow :)

@goeranhomberg
Copy link

Same problem here:

ng2-bootstrap/components/utils/components-helper.service.d.ts(2,10): error TS2305: Module '.../client/node_modules/@angular/core/src/facade/lang"' has no exported member 'ConcreteType'.

a new release would be nice :)

@isaackehle
Copy link
Author

Thank you for the quick work!

@elirenato
Copy link

elirenato commented Sep 2, 2016

Thank you!, I just updated my project and it's working.

@valorkin
Copy link
Member

valorkin commented Sep 3, 2016

Glad to hear it helped :)

@ashwinirajput
Copy link

import { Component,OnInit,ModuleWithProviders,ViewContainerRef,Injector,DynamicComponentLoader} from '@angular/core';
file: 'file:///Users/ashwini/Documents/angular-quickstart/app/app.component.ts'
severity: 'Error'
'"/Documents/angular-quickstart/node_modules/@angular/core/index"'
has no exported member 'DynamicComponentLoader'.'

@valorkin
Copy link
Member

Update ng2 bootstrap to latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants