-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to rc.6 #908
Update to rc.6 #908
Conversation
otelnov
commented
Sep 1, 2016
- move pipes to ngModel
- stop using internal API (@angular/core/src/facade/lang)
- Type instead of ConcreteType
@otelnov thanks for RC6 branch! As mentioned in your RC5 PR:
Any news when this PR will be merged? I'm asking because your RC5 PR is pending since 13 days and I'm getting impatient and thinking about to switch to https://github.com/ng-bootstrap/ng-bootstrap which supports RC6 already (and it supports RC5 since 22 days) and it looks good to me... I'm asking myself why there must be two Angular 2 bootstrap projects :/ ? |
Current coverage is 90.24% (diff: 100%)
@@ development #908 diff @@
=============================================
Files 25 25
Lines 769 769
Methods 142 142
Messages 0 0
Branches 112 112
=============================================
+ Hits 663 694 +31
+ Misses 106 75 -31
Partials 0 0
|
I've started using the feat-rc6 branch, but with modals I get a "view.getComputedStyle is not a function" when triggering. Any idea what that is? Edit: sorry just realizing you're still working on it. I thought I was pointing out something you might have misse.d. Thanks |
@PEsteves8 I think the reason is that @otelnov used |
see PR #909 |