Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rc.6 #908

Merged
merged 1 commit into from
Sep 1, 2016
Merged

Update to rc.6 #908

merged 1 commit into from
Sep 1, 2016

Conversation

otelnov
Copy link
Contributor

@otelnov otelnov commented Sep 1, 2016

  • move pipes to ngModel
  • stop using internal API (@angular/core/src/facade/lang)
  • Type instead of ConcreteType

@Martin-Luft
Copy link
Contributor

@otelnov thanks for RC6 branch! As mentioned in your RC5 PR:

I found 2 other files which should be updated:

Main README lines 57-59 and 121: deprecated directives:

ng2-bootstrap.ts lines 56-81: all deprecated

Any news when this PR will be merged? I'm asking because your RC5 PR is pending since 13 days and I'm getting impatient and thinking about to switch to https://github.com/ng-bootstrap/ng-bootstrap which supports RC6 already (and it supports RC5 since 22 days) and it looks good to me... I'm asking myself why there must be two Angular 2 bootstrap projects :/ ?

@codecov-io
Copy link

codecov-io commented Sep 1, 2016

Current coverage is 90.24% (diff: 100%)

Merging #908 into development will increase coverage by 4.03%

@@           development       #908   diff @@
=============================================
  Files               25         25          
  Lines              769        769          
  Methods            142        142          
  Messages             0          0          
  Branches           112        112          
=============================================
+ Hits               663        694    +31   
+ Misses             106         75    -31   
  Partials             0          0          

Powered by Codecov. Last update 2cc2722...1874ef5

@PEsteves8
Copy link

PEsteves8 commented Sep 1, 2016

I've started using the feat-rc6 branch, but with modals I get a "view.getComputedStyle is not a function" when triggering. Any idea what that is?

Edit: sorry just realizing you're still working on it. I thought I was pointing out something you might have misse.d. Thanks

@valorkin valorkin merged commit 34338a8 into development Sep 1, 2016
@valorkin valorkin deleted the feat-rc6 branch September 1, 2016 13:32
@Martin-Luft
Copy link
Contributor

@PEsteves8 I think the reason is that @otelnov used type instead of window for the global substitutions :(

@Martin-Luft
Copy link
Contributor

see PR #909

@hongbo-miao hongbo-miao mentioned this pull request Sep 1, 2016
valorkin pushed a commit that referenced this pull request Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants