Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Could you support the slideFactorY and slideFactorX options ? #1086

Open
3 tasks done
ValerioEmanuele opened this issue Feb 16, 2023 · 2 comments
Open
3 tasks done

Comments

@ValerioEmanuele
Copy link

ValerioEmanuele commented Feb 16, 2023

REQUIRED: Before filing a feature request

  • My issue title starts with [feature request].
  • I have thoroughly read through the README, and the dragula docs.
  • I have searched through the ng2-dragula issues for related problems, including closed issues, and I didn't find anything.

Is your feature request related to a problem? Please describe.
Hello,
I need to ignore the drag & drop when the users do a little movement because this is causing some issues.

Describe the solution you'd like
I saw that inside, you're using the following dependency:
"@types/dragula": "^2.1.34",

And the slideFactorY and slideFactorX properties are not present in this version on the interface DragulaOptions although Dragula has supported them for several years.

A clear and concise description of what you want to happen.

Describe alternatives you've considered

I limited the drag & drop area using the options you provided, e.g., moves(), revertOnSpill, removeOnSpill, etc. But they are never called because the movement is so little that they are not considered.

@ValerioEmanuele
Copy link
Author

ValerioEmanuele commented Aug 31, 2023

@valorkin , @cormacrelf, any chance to have it implemented?

@ValerioEmanuele
Copy link
Author

Hello @cormacrelf , @valorkin

I hope this message finds you well. I am reaching out to bring your attention to this issue.

In support of this feature request, I have contributed a PR to the DefinitelyTyped repository that has been successfully merged. You can view the PR here: DefinitelyTyped/DefinitelyTyped#69382. This PR introduces the slideFactorX and slideFactorY properties, which I believe could significantly enhance the drag-and-drop functionality in ng2-dragula by allowing fine control over the drag sensitivity.

I kindly request that you consider reviewing and integrating these enhancements into the ng2-dragula project. Implementing these properties could simplify the adoption of customized drag thresholds for many developers using your library.

Thank you for considering this integration. I look forward to your feedback and hope for a positive response.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant