Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to Angular 2.0.0 #393

Open
uzumakinaruto123 opened this issue Sep 5, 2016 · 9 comments
Open

Upgrade project to Angular 2.0.0 #393

uzumakinaruto123 opened this issue Sep 5, 2016 · 9 comments

Comments

@uzumakinaruto123
Copy link

uzumakinaruto123 commented Sep 5, 2016

Cant upgrade angular and other angular rc6 based modules due to this :-

Peer ng2-select@1.0.3 wants @angular/common@^2.0.0-rc.1

would it be possible to upgrade ng2-select too ?

Edit :- Since Angular 2.0.0 is out , and other modules are already being updated.

@smyth64
Copy link

smyth64 commented Sep 5, 2016

I just found these forks which have updated to rc6 already

aslubsky@2b940a2
https://github.com/chymz/ng2-select/commit/e35184a12e91a1f74676c6af0de7f24e470de37d

Try your luck :D

@uzumakinaruto123
Copy link
Author

Thanks ! That would help for time being 👍

@lacma2011
Copy link

I have used the link to aslubsky and it works. However, I could not get it to work for the angular compiler to bootstrap with ahead-of-time compilation

@ghost
Copy link

ghost commented Sep 8, 2016

Is there an example of how to load by NgModule? or just we need to add in NgModule.declarations importing SelectComponent ?

@Namek
Copy link
Contributor

Namek commented Sep 9, 2016

besides SelectComponent there is OffClickDirective and HighlightPipe. However, even adding them to NgModule.declarations there is an error because SelectComponent defines directives which is illegal with NgModule in RC6.

@theunreal
Copy link

Waiting for RC6 version, hope the forks will be published soon to npm..

@smyth64
Copy link

smyth64 commented Sep 11, 2016

@Namek
Changing the directives: ... stuff to the ngModule shouldn't be the problem =)

I'm curious if anyone already have a working version.

@lukefarran
Copy link

lukefarran commented Sep 12, 2016

I have used the link to aslubsky's fork, and like lacma2011, I found that AoT doesn't work. I also found that if you have multiple ng-selects on a page, when you click on one it opens all of them.

It appears that the AoT issue can be fixed by moving the template in select/select.ts into a HTM file and use templateUrl instead of template for @component:
@component({
selector: 'ng-select',
templateUrl: 'select.html'
})

@GreenToast
Copy link

Even the *.metadata.json-files need to be generated for aot-compilation, regarding this issue in ng2-bootstrap valor-software/ngx-bootstrap#933

@uzumakinaruto123 uzumakinaruto123 changed the title Upgrade project to RC6 Upgrade project to RC6 Edit- Angular 2.0.0 Sep 19, 2016
@uzumakinaruto123 uzumakinaruto123 changed the title Upgrade project to RC6 Edit- Angular 2.0.0 Upgrade project to Angular 2.0.0 Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants