Skip to content

Commit 7fc365e

Browse files
fix(common): fix ci latest (#5650)
* fix(common): fix ci latest Fix ci latest, change typescript version to 3.7.5 * fix(tests): fix position service test to pass with latest Angular version Co-authored-by: Dmitriy Danilov <daniloff200@gmail.com>
1 parent 3e9046f commit 7fc365e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

scripts/ci/npm-ng-latest.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ npm i @angular/animations@latest \
1717
@angular/router@latest \
1818
@angular/service-worker@latest \
1919
@schematics/angular@latest \
20-
typescript@3.5.3 \
20+
@types/node@latest \
21+
typescript@3.7.5 \
2122
tsickle@0.35.0 \
2223
rxjs@6.5.2

src/spec/ng-bootstrap/popover.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,9 +275,9 @@ describe('popover', () => {
275275
expect(windowEl.textContent.trim()).toBe('Great tip!');
276276
});
277277

278-
it('should set position to right when use auto position and fit on screen', () => {
278+
it('should set position to top when use auto position and fit on screen', () => {
279279
const fixture = createTestComponent(
280-
`<div style="padding: 400px"><div popover="Great tip!" placement="auto"></div></div>`
280+
`<div style="padding: 400px"><div popover="Great tip!" placement="auto right"></div></div>`
281281
);
282282
const directive = fixture.debugElement.query(
283283
By.directive(PopoverDirective)
@@ -289,7 +289,7 @@ describe('popover', () => {
289289

290290
expect(windowEl).toHaveCssClass('popover');
291291
expect(windowEl).toHaveCssClass('popover-auto');
292-
expect(windowEl).toHaveCssClass('top');
292+
expect(windowEl).toHaveCssClass('right');
293293
expect(windowEl.textContent.trim()).toBe('Great tip!');
294294
});
295295

src/spec/ng-bootstrap/tooltip.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ describe('tooltip', () => {
243243

244244
it('should use auto position', () => {
245245
const fixture = createTestComponent(
246-
`<div style="padding:400px"><div tooltip="Great tip!" placement="auto"></div></div>`
246+
`<div style="padding:400px"><div tooltip="Great tip!" placement="auto top"></div></div>`
247247
);
248248
const directive = fixture.debugElement.query(
249249
By.directive(TooltipDirective)

0 commit comments

Comments
 (0)