Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tooltips): not aligned in demo #141

Closed
kellerapps opened this issue Feb 4, 2016 · 6 comments
Closed

chore(tooltips): not aligned in demo #141

kellerapps opened this issue Feb 4, 2016 · 6 comments
Milestone

Comments

@kellerapps
Copy link

http://valor-software.com/ng2-bootstrap/#getting-started
The tooltips are not aligned w/ their elements.

The tooltip on Datepicker demo doesn't appear.

@valorkin valorkin changed the title tooltips not aligned in demo chore(tooltips): not aligned in demo Feb 4, 2016
@valorkin
Copy link
Member

valorkin commented Feb 4, 2016

Problem is bigger than you think, modals\popups\tooltips are pain in the code in ng2 as for now
I need to properly export position service and reuse it across all elements

@valorkin
Copy link
Member

implemented tooltips demo now aligned

@sqwk
Copy link

sqwk commented Apr 3, 2016

Possibly related: the v4 bootstrap tooltips are missing their arrows.

@valorkin valorkin added this to the beta.14 milestone Apr 4, 2016
@valorkin
Copy link
Member

valorkin commented Apr 4, 2016

interesting things about arrows in bs4
they are missing in bs4 off documentation
tooltip container has all this new classes
and in bs4 tooltip can be attached only to document.body
tooltip bs-tether-element bs-tether-abutted bs-tether-abutted-top bs-tether-element-attached-bottom bs-tether-element-attached-center bs-tether-target-attached-top bs-tether-target-attached-center fade bs-tether-enabled in

@sqwk
Copy link

sqwk commented Apr 4, 2016

Does this mean that tether.min.js needs to be included alongside ng-bootstrap as per the v4 documentation?

@valorkin
Copy link
Member

valorkin commented Apr 4, 2016

not sure to be honest, I see where it is came from
https://github.com/twbs/bootstrap/blob/v4-dev/js/src/tooltip.js#L36

right now I am fixing system.js bundles, I will get to this a bit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants