feat(modal): add dissmissReason, fix body padding, add events section… #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2131 +/- ##
===============================================
+ Coverage 87.13% 87.31% +0.17%
===============================================
Files 85 85
Lines 2262 2309 +47
Branches 292 301 +9
===============================================
+ Hits 1971 2016 +45
- Misses 188 190 +2
Partials 103 103
Continue to review full report at Codecov.
|
valorkin
reviewed
Jun 27, 2017
src/modal/modal.component.ts
Outdated
| @@ -89,7 +91,7 @@ export class ModalDirective implements AfterViewInit, OnDestroy { | |||
| if (this.config.ignoreBackdropClick || this.config.backdrop === 'static' || event.target !== this._element.nativeElement) { | |||
| return; | |||
| } | |||
|
|
|||
| this.dismissReason = 'backdrop-click'; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
valorkin
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1964
fixes #2004