Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): reactive forms in onpush components #2947

Merged
merged 2 commits into from
Nov 2, 2017

Conversation

valorkin
Copy link
Member

@valorkin valorkin commented Nov 1, 2017

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Nov 1, 2017

Codecov Report

❗ No coverage uploaded for pull request base (development@5662e20). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             development   #2947   +/-   ##
=============================================
  Coverage               ?   70.7%           
=============================================
  Files                  ?     137           
  Lines                  ?    4165           
  Branches               ?     737           
=============================================
  Hits                   ?    2945           
  Misses                 ?     914           
  Partials               ?     306

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5662e20...47b2f56. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 69bd6fa into development Nov 2, 2017
@valorkin valorkin deleted the fix-datepicker-reactive-in-onpush branch November 2, 2017 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants