Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker) : min mode, sets a lower limit for view mode (day, month, year) #3354

Merged

Conversation

rrambaud
Copy link

@rrambaud rrambaud commented Dec 24, 2017

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • [ x] read and followed the CONTRIBUTING.md guide.
  • [ x] built and tested the changes locally.
  • [ x] added/updated tests.
  • [ x] added/updated API documentation.
  • [ x] added/updated demos.

@codecov
Copy link

codecov bot commented Dec 24, 2017

Codecov Report

Merging #3354 into development will decrease coverage by 3.61%.
The diff coverage is 73.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3354      +/-   ##
===============================================
- Coverage        75.65%   72.04%   -3.62%     
===============================================
  Files              237      258      +21     
  Lines             7336     8391    +1055     
  Branches          1464     1653     +189     
===============================================
+ Hits              5550     6045     +495     
- Misses            1376     1889     +513     
- Partials           410      457      +47
Impacted Files Coverage Δ
src/datepicker/reducer/bs-datepicker.state.ts 100% <ø> (ø)
src/datepicker/bs-datepicker.config.ts 100% <ø> (ø)
src/datepicker/engine/view-mode.ts 100% <100%> (ø)
src/datepicker/bs-datepicker.component.ts 37.17% <50%> (ø)
src/datepicker/reducer/bs-datepicker.reducer.ts 20.15% <77.77%> (ø)
src/dropdown/bs-dropdown-menu.directive.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/cs.ts 67.24% <0%> (-19.2%) ⬇️
src/tabs/tab-heading.directive.ts 66.66% <0%> (-13.34%) ⬇️
src/popover/popover-container.component.ts 90.9% <0%> (-9.1%) ⬇️
src/carousel/slide.component.ts 91.66% <0%> (-8.34%) ⬇️
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d2734...ab39d24. Read the comment docs.

@rrambaud rrambaud changed the title Datepicker min mode feat(datepicker) : min mode, sets a lower limit for view mode (day, month, year) Dec 26, 2017
@rrambaud
Copy link
Author

Created from feature request #2627
Exists in AngularJS UI Bootstrap - http://angular-ui.github.io/bootstrap/versioned-docs/1.3.3/#/datepicker
Exists in ngx-bootstrap old datepicker

}
else {
mode = state.view.mode
newState = { selectedDate: date, view: { date, mode } };

This comment was marked as off-topic.

@valorkin
Copy link
Member

valorkin commented Jan 5, 2018

@rrambaud looks good to me overall, I will get to merge it a bit later

thanks for your help!

@YevheniiaMazur
Copy link

Has conflicting files. needs fix

@rrambaud
Copy link
Author

I've fixed the conflicts

@ghost
Copy link

ghost commented Mar 5, 2018

Hi,

I was wondering when this pull request can be finalized? We really need the possiblity to configure the datepicker with different modes.

Thanks,
Drazen

@rrambaud
Copy link
Author

At least it's up to date

@ghost
Copy link

ghost commented Mar 22, 2018

Please, is there any progress to expect soon? We need to figure out whether we will use this component or not.

Thanks

@ghost
Copy link

ghost commented Apr 20, 2018

Hi, do you have any updates on this maybe?

Thanks,
Drazen

@Frennetix
Copy link

Any news on this?

@TreesAndMountains
Copy link

TreesAndMountains commented Jun 5, 2018

What's the status on this PR?

@ghost
Copy link

ghost commented Jun 13, 2018

I think this PR will never be completed, looking at how much time it took so far

@valorkin
Copy link
Member

Starting from monday full time dev will be assigned to ngx-bs, so things should get on speed again

@Frennetix
Copy link

So.. is it progressing?

@ghost
Copy link

ghost commented Jul 9, 2018

Apparently not.

@bandhavya
Copy link

any updates on this?

@ducminhquan
Copy link

Any updates on this?

@RookieLittleFatty
Copy link

RookieLittleFatty commented Sep 19, 2018

hey, I don't know much about github, so i can't understand the PR and merge about this feature.
Have your PR been merged in any version? Can i use it now? Could you tell me how? Thanks!

@mgpGit-zz
Copy link

What's the status on this feature? Is anyone working on it?

@santosmken
Copy link

What is the status of this feature?

@valor-software valor-software deleted a comment Nov 28, 2018
@valorkin
Copy link
Member

@Domainv lets make n+1 release with most of datepicker PRs

@Domainv
Copy link
Contributor

Domainv commented Nov 30, 2018

roger that

@Domainv Domainv changed the base branch from development to feat-datepicker-min-mode December 3, 2018 13:59
@Domainv Domainv changed the base branch from feat-datepicker-min-mode to development December 3, 2018 14:06
@ghost ghost assigned Domainv Dec 3, 2018
@Domainv Domainv changed the base branch from development to feat-datepicker-min-mode December 3, 2018 15:07
@Domainv Domainv changed the base branch from feat-datepicker-min-mode to development December 3, 2018 15:13
@Domainv Domainv changed the base branch from development to feat-datepicker-min-mode December 3, 2018 15:16
@Domainv Domainv merged commit c602830 into valor-software:feat-datepicker-min-mode Dec 3, 2018
@ghost ghost removed the needs review label Dec 3, 2018
@Domainv Domainv mentioned this pull request Dec 3, 2018
5 tasks
valorkin pushed a commit that referenced this pull request Dec 5, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.