-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datepicker) : min mode, sets a lower limit for view mode (day, month, year) #3354
feat(datepicker) : min mode, sets a lower limit for view mode (day, month, year) #3354
Conversation
Codecov Report
@@ Coverage Diff @@
## development #3354 +/- ##
===============================================
- Coverage 75.65% 72.04% -3.62%
===============================================
Files 237 258 +21
Lines 7336 8391 +1055
Branches 1464 1653 +189
===============================================
+ Hits 5550 6045 +495
- Misses 1376 1889 +513
- Partials 410 457 +47
Continue to review full report at Codecov.
|
Created from feature request #2627 |
} | ||
else { | ||
mode = state.view.mode | ||
newState = { selectedDate: date, view: { date, mode } }; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
@rrambaud looks good to me overall, I will get to merge it a bit later thanks for your help! |
Has conflicting files. needs fix |
I've fixed the conflicts |
Hi, I was wondering when this pull request can be finalized? We really need the possiblity to configure the datepicker with different modes. Thanks, |
At least it's up to date |
Please, is there any progress to expect soon? We need to figure out whether we will use this component or not. Thanks |
Hi, do you have any updates on this maybe? Thanks, |
…-bootstrap into datepicker-min-mode
Any news on this? |
What's the status on this PR? |
I think this PR will never be completed, looking at how much time it took so far |
Starting from monday full time dev will be assigned to ngx-bs, so things should get on speed again |
So.. is it progressing? |
Apparently not. |
any updates on this? |
Any updates on this? |
hey, I don't know much about github, so i can't understand the PR and merge about this feature. |
What's the status on this feature? Is anyone working on it? |
What is the status of this feature? |
@Domainv lets make n+1 release with most of datepicker PRs |
roger that |
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.