Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progressbar): fix bs4, animation, add striped option, remove bs4 demos #3500

Merged
merged 2 commits into from
Jan 19, 2018

Conversation

IlyaSurmay
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

BREAKING CHANGES:
Removed ProgressDirective

valorkin
valorkin previously approved these changes Jan 19, 2018
@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #3500 into development will increase coverage by 0.2%.
The diff coverage is 95.45%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #3500     +/-   ##
==============================================
+ Coverage        72.07%   72.27%   +0.2%     
==============================================
  Files              251      249      -2     
  Lines             8149     8098     -51     
  Branches          1548     1536     -12     
==============================================
- Hits              5873     5853     -20     
+ Misses            1850     1821     -29     
+ Partials           426      424      -2
Impacted Files Coverage Δ
src/progressbar/progressbar.module.ts 100% <ø> (ø) ⬆️
src/progressbar/index.ts 100% <ø> (ø) ⬆️
src/progressbar/progressbar.config.ts 100% <100%> (ø) ⬆️
src/progressbar/progressbar.component.ts 93.33% <100%> (-0.42%) ⬇️
src/index.ts 100% <100%> (ø) ⬆️
src/progressbar/bar.component.ts 90.32% <75%> (+3.65%) ⬆️
src/datepicker/bs-daterangepicker.component.ts 34.66% <0%> (-0.86%) ⬇️
src/datepicker/datepicker.module.ts 92.3% <0%> (-0.55%) ⬇️
...c/datepicker/bs-daterangepicker-input.directive.ts 27.14% <0%> (-0.13%) ⬇️
src/datepicker/bs-datepicker.config.ts 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b43295...8ca2b66. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants