Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chronos): add indonesia locale #3532

Merged
merged 2 commits into from
Feb 5, 2018
Merged

feat(chronos): add indonesia locale #3532

merged 2 commits into from
Feb 5, 2018

Conversation

rkusuma
Copy link
Contributor

@rkusuma rkusuma commented Jan 24, 2018

  • add id locale
  • add id locale test
  • update id locale in demo datepicker

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated demos.

- add id locale
- add id locale test
- update id locale in demo datepicker
@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #3532 into development will decrease coverage by 0.01%.
The diff coverage is 52.94%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3532      +/-   ##
===============================================
- Coverage        72.07%   72.05%   -0.02%     
===============================================
  Files              251      252       +1     
  Lines             8142     8159      +17     
  Branches          1544     1552       +8     
===============================================
+ Hits              5868     5879      +11     
- Misses            1851     1858       +7     
+ Partials           423      422       -1
Impacted Files Coverage Δ
src/locale.ts 100% <100%> (ø) ⬆️
src/chronos/i18n/id.ts 50% <50%> (ø)
src/chronos/i18n/pl.ts 77.77% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09f0f9...99bb4f4. Read the comment docs.

Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

valorkin
valorkin previously approved these changes Jan 24, 2018
- add meririem test case
@YevheniiaMazur
Copy link

tested, looks good

@valorkin valorkin merged commit 8ba8b18 into valor-software:development Feb 5, 2018
@ghost ghost removed the ready for merge label Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants