Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): fix demo header static position for safari browser #3600

Conversation

artolshansky
Copy link
Contributor

close #3312

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #3600 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3600   +/-   ##
============================================
  Coverage        72.07%   72.07%           
============================================
  Files              251      251           
  Lines             8142     8142           
  Branches          1544     1544           
============================================
  Hits              5868     5868           
  Misses            1851     1851           
  Partials           423      423

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c09f0f9...d30e239. Read the comment docs.

@@ -296,6 +296,7 @@ a:hover {
}
/* content */
.main-container {
padding-top: 30px;

This comment was marked as off-topic.

This comment was marked as off-topic.

@artolshansky artolshansky force-pushed the docs-fix-documentation-header branch from c6f3bf1 to f40deca Compare January 31, 2018 12:52
@@ -512,9 +512,12 @@ a:hover {
/*** Media Query ***/
/* above 768px */
@media (min-width: 768px) {
.main {

This comment was marked as off-topic.

@artolshansky artolshansky force-pushed the docs-fix-documentation-header branch from f40deca to d30e239 Compare January 31, 2018 13:16
@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 2f0e7f8 into valor-software:development Mar 1, 2018
@ghost ghost removed the ready for merge label Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(demo): demo header is not static for safari browser
4 participants