fix(typeahead): incoming data are not filtered after typeahead kicks-in #3728
Conversation
IraErshova
force-pushed
the
fix-typeahead-async-filter
branch
2 times, most recently
from
af2e229 to
1552274
Compare
Codecov Report
@@ Coverage Diff @@
## development #3728 +/- ##
============================================
Coverage 52.52% 52.52%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 52 52
Misses 37 37
Partials 10 10Continue to review full report at Codecov.
|
src/typeahead/typeahead.directive.ts
Outdated
| .mergeMap((value: string) => { | ||
| const normalizedQuery = this.normalizeQuery(value); | ||
|
|
||
| return this.typeahead.map((data: any[]) => { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
typeahead has type any in the whole module. Adding type for this instance should be a separate issue.
src/typeahead/typeahead.directive.ts
Outdated
| @@ -344,7 +344,15 @@ export class TypeaheadDirective implements OnInit, OnDestroy { | |||
| this._subscriptions.push( | |||
| this.keyUpEventEmitter | |||
| .debounceTime(this.typeaheadWaitMs) | |||
| .mergeMap(() => this.typeahead) | |||
| .mergeMap((value: string) => { | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
value: string is not typing for typeahead. This code is correct and doesn't break anything
IraErshova
force-pushed
the
fix-typeahead-async-filter
branch
from
1552274 to
69d2def
Compare
IraErshova
force-pushed
the
fix-typeahead-async-filter
branch
2 times, most recently
from
757f29b to
02fb28d
Compare
valor-software#3725 Fix filtering incoming data after typeahead kicks-in Close valor-software#3725
IraErshova
force-pushed
the
fix-typeahead-async-filter
branch
from
46674e9 to
0664d8f
Compare
|
Tested. Issues were fixed by @IraErshova . Ready to merge |
|
@dmitry-zhemchugov has to be tested with real XHR as a source of data |
Fix filtering incoming data after typeahead kicks-in. Remove filtering functionality from demo code to ngx-bootstrap component's code.
Close #3725
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.