Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): revert changes for accordion key nav support #4093

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

EvilAlexei
Copy link
Contributor

@EvilAlexei EvilAlexei commented Mar 26, 2018

Because of breaking changes need to revert new html structure of accordion, main template and Custom html demo.

  • Revert accordion component template, changed button to div
  • Revert accordion demo Custom html, changed button to div

Actual result:

download 1

Expected result:

download

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

- Revert accordion component template, changed `button` to `div`
- Revert accordion demo `Custom html`, changed `button` to `div`
@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #4093 into development will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4093      +/-   ##
===============================================
- Coverage        72.23%   72.17%   -0.07%     
===============================================
  Files              252      252              
  Lines             8237     8237              
  Branches          1565     1565              
===============================================
- Hits              5950     5945       -5     
- Misses            1866     1868       +2     
- Partials           421      424       +3
Impacted Files Coverage Δ
src/chronos/i18n/it.ts 71.42% <0%> (-28.58%) ⬇️
src/chronos/i18n/pl.ts 72.22% <0%> (-5.56%) ⬇️
src/chronos/i18n/uk.ts 78.04% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a384d9...11400a6. Read the comment docs.

@YevheniiaMazur
Copy link

Tested, looks good

@valorkin valorkin merged commit 8a46e6e into development Apr 5, 2018
@ghost ghost removed the ready for merge label Apr 5, 2018
@valorkin valorkin deleted the feat-exclude-accordion-key-nav branch April 5, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants