-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): fix bottom position for dropdownlist #4626
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs review
label
Sep 19, 2018
Codecov Report
@@ Coverage Diff @@
## development #4626 +/- ##
===============================================
+ Coverage 74.7% 74.85% +0.14%
===============================================
Files 276 276
Lines 8385 8390 +5
Branches 1594 1594
===============================================
+ Hits 6264 6280 +16
+ Misses 1682 1670 -12
- Partials 439 440 +1
Continue to review full report at Codecov.
|
IlyaSurmay
previously approved these changes
Sep 25, 2018
code coverage test |
Domainv
previously approved these changes
Dec 11, 2018
ghost
added
the
needs review
label
Dec 11, 2018
ghost
assigned Domainv
Dec 11, 2018
Domainv
approved these changes
Dec 11, 2018
Dropdowns demo tested in CHrome, FF - looks good. |
valorkin
approved these changes
Dec 12, 2018
ghost
assigned valorkin
Dec 12, 2018
ghost
removed
the
ready for merge
label
Dec 12, 2018
leo6104
pushed a commit
to leo6104/ngx-bootstrap
that referenced
this pull request
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes to #4545
it fixed dropdown list bottom position. If the user is using bootstrap 4, directive adds transform style, and bottom style (bottom: 100%) is redundant