Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): fix bottom position for dropdownlist #4626

Merged
merged 4 commits into from Dec 12, 2018
Merged

fix(dropdown): fix bottom position for dropdownlist #4626

merged 4 commits into from Dec 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2018

Closes to #4545
it fixed dropdown list bottom position. If the user is using bootstrap 4, directive adds transform style, and bottom style (bottom: 100%) is redundant

@ghost ghost added the needs review label Sep 19, 2018
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #4626 into development will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4626      +/-   ##
===============================================
+ Coverage         74.7%   74.85%   +0.14%     
===============================================
  Files              276      276              
  Lines             8385     8390       +5     
  Branches          1594     1594              
===============================================
+ Hits              6264     6280      +16     
+ Misses            1682     1670      -12     
- Partials           439      440       +1
Impacted Files Coverage Δ
src/dropdown/bs-dropdown.directive.ts 85.92% <100%> (+6.97%) ⬆️
src/datepicker/reducer/bs-datepicker.effects.ts 72.47% <0%> (-1.84%) ⬇️
src/tooltip/tooltip-container.component.ts 76.47% <0%> (ø) ⬆️
src/typeahead/typeahead.directive.ts 74.86% <0%> (+1.04%) ⬆️
src/tooltip/tooltip.directive.ts 60% <0%> (+1.12%) ⬆️
src/datepicker/engine/flag-days-calendar.ts 80% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c545860...0984785. Read the comment docs.

IlyaSurmay
IlyaSurmay previously approved these changes Sep 25, 2018
@Domainv
Copy link
Contributor

Domainv commented Sep 28, 2018

code coverage test

@ghost ghost added the needs review label Dec 3, 2018
@valorkin valorkin modified the milestones: 3.1.3, 3.1.4 Dec 3, 2018
@Domainv Domainv added this to the 3.1.4 milestone Dec 7, 2018
Domainv
Domainv previously approved these changes Dec 11, 2018
@ghost ghost added the needs review label Dec 11, 2018
@ghost ghost assigned Domainv Dec 11, 2018
@ludmilanesvitiy
Copy link
Contributor

Dropdowns demo tested in CHrome, FF - looks good.

@ghost ghost assigned valorkin Dec 12, 2018
@valorkin valorkin merged commit 6e04b33 into valor-software:development Dec 12, 2018
@ghost ghost removed the ready for merge label Dec 12, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants