Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo(datepicker): fix date's displaying in reactive form section #4771

Merged
merged 2 commits into from Dec 5, 2018
Merged

demo(datepicker): fix date's displaying in reactive form section #4771

merged 2 commits into from Dec 5, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2018 •
edited by ghost
Loading

When a user choose the previous date:

Actual result:
joxi_screenshot_1541176195637
Expected result:
joxi_screenshot_1541177273090

Related to #4464

@ghost ghost added the needs review label Nov 2, 2018
@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #4771 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4771   +/-   ##
============================================
  Coverage        74.34%   74.34%           
============================================
  Files              202      202           
  Lines             7102     7102           
  Branches          1447     1447           
============================================
  Hits              5280     5280           
  Misses            1426     1426           
  Partials           396      396
Impacted Files Coverage Δ
src/chronos/i18n/cs.ts 84.74% <0%> (ø) ⬆️
src/chronos/i18n/pl.ts 77.77% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a003011...2fc77db. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 7, 2018 •
edited
Loading

Codecov Report

Merging #4771 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4771   +/-   ##
============================================
  Coverage        74.46%   74.46%           
============================================
  Files              205      205           
  Lines             7190     7190           
  Branches          1464     1464           
============================================
  Hits              5354     5354           
  Misses            1435     1435           
  Partials           401      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d583f74...8df468d. Read the comment docs.

@ghost ghost assigned Domainv Nov 7, 2018
Domainv
Domainv previously approved these changes Nov 7, 2018
View reviewed changes
@ludmilanesvitiy
Copy link
Contributor

screenshot from 2018-11-13 12-30-19
Tested, need to improve view with chosen date, should be without horizontal scrolls.

@ghost
Copy link
Author

ghost commented Nov 13, 2018

@ludmilanesvitiy fixed

@ludmilanesvitiy
Copy link
Contributor

Tested in Chrome + FF - datepicker reactive forms demo looks good.

@valorkin valorkin added this to the 3.1.3 milestone Dec 3, 2018
@valorkin valorkin merged commit 9671c7e into valor-software:development Dec 5, 2018
@ludmilanesvitiy ludmilanesvitiy mentioned this pull request May 13, 2019
Open
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@leo6104
fix(datepicker): fix datepickers cypress test (valor-software#4771)
a81bbf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@valorkin valorkin

@Domainv Domainv

Labels
comp(demo) ready for merge ready for review
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ludmilanesvitiy @valorkin @Domainv